Skip to content

drivers/wifi/nrfwifi: Add buffer for discard bytes #80787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2024
Merged

drivers/wifi/nrfwifi: Add buffer for discard bytes #80787

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion drivers/wifi/nrfwifi/src/qspi/src/spi_if.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@
addr & 0xFF,
0 /* dummy byte */
};
uint8_t discard[sizeof(hdr) + 2 * 4];

const struct spi_buf tx_buf[] = {
{.buf = hdr, .len = sizeof(hdr) },
Expand All @@ -67,12 +68,17 @@
const struct spi_buf_set tx = { .buffers = tx_buf, .count = 2 };

const struct spi_buf rx_buf[] = {
{.buf = NULL, .len = sizeof(hdr) + discard_bytes},
{.buf = discard, .len = sizeof(hdr) + discard_bytes},
{.buf = data, .len = len },
};

Check notice on line 73 in drivers/wifi/nrfwifi/src/qspi/src/spi_if.c

View workflow job for this annotation

GitHub Actions / Run compliance checks on patch series (PR)

You may want to run clang-format on this change 

drivers/wifi/nrfwifi/src/qspi/src/spi_if.c:73 
-		{.buf = discard,  .len = sizeof(hdr) + discard_bytes},
-		{.buf = data, .len = len },
+		{.buf = discard, .len = sizeof(hdr) + discard_bytes},
+		{.buf = data, .len = len},

Check notice on line 73 in drivers/wifi/nrfwifi/src/qspi/src/spi_if.c

View workflow job for this annotation

GitHub Actions / Run compliance checks on patch series (PR)

You may want to run clang-format on this change 

drivers/wifi/nrfwifi/src/qspi/src/spi_if.c:73 
-		{.buf = discard,  .len = sizeof(hdr) + discard_bytes},
-		{.buf = data, .len = len },
+		{.buf = discard, .len = sizeof(hdr) + discard_bytes},
+		{.buf = data, .len = len},

const struct spi_buf_set rx = { .buffers = rx_buf, .count = 2 };

if (rx_buf[0].len > sizeof(discard)) {
LOG_ERR("Discard bytes too large, please adjust buf size");
return -EINVAL;
}

return spi_transceive_dt(&spi_spec, &tx, &rx);
}

Expand Down
Loading