Skip to content

Conversation

@vishwamartur
Copy link

Related to #80578

Add the GC9X01X_CMD_INVON command to the default_init_regs array in drivers/display/display_gc9x01x.c to set color inversion to false.

  • Update the gc9x01x_regs_init function to include the new command in the initialization sequence.
  • Set the default value of the display-inversion property to false in dts/bindings/display/galaxycore,gc9x01x.yaml.

Related to zephyrproject-rtos#80578

Add the `GC9X01X_CMD_INVON` command to the `default_init_regs` array in `drivers/display/display_gc9x01x.c` to set color inversion to false.

* Update the `gc9x01x_regs_init` function to include the new command in the initialization sequence.
* Set the default value of the `display-inversion` property to false in `dts/bindings/display/galaxycore,gc9x01x.yaml`.
Copy link
Contributor

@danieldegrasse danieldegrasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending in this fix!

Since we are in the bug fixing phase of this release, this PR will need to directly reference #80791. Please update the reference within the commit message to be formatted like so:

Fixes #80791, and do the same for the PR description.

Beyond this, can you take a look at the compliance failure error reported?

 1: UC2 Commit message does not contain a 'Signed-off-by:' line
1: UC3 Commit title does not follow [subsystem]: [subject] (and should not start with literal subsys or treewide): "Fix color inversion issue in GC9X01X display driver"
5: UC4 Commit message body line exceeds max length (140>75): "Add the `GC9X01X_CMD_INVON` command to the `default_init_regs` array in `drivers/display/display_gc9x01x.c` to set color inversion to false."
7: UC4 Commit message body line exceeds max length (100>75): "* Update the `gc9x01x_regs_init` function to include the new command in the initialization sequence."
8: UC4 Commit message body line exceeds max length (119>75): "* Set the default value of the `display-inversion` property to false in `dts/bindings/display/galaxycore,gc9x01x.yaml`."
Error: See https://docs.zephyrproject.org/latest/contribute/guidelines.html#commit-guidelines for more details

 5622741a0e5559c24c4f825349390ff91a4f12ca: author email (Vishwanath Martur <[email protected]>) must be a real email and cannot end in @users.noreply.github.com
Compliance error, check for error messages in the "Run Compliance Tests" step
You can run this step locally with the ./scripts/ci/check_compliance.py script.

@kartben kartben requested a review from MrMarteng November 7, 2024 13:30
@github-actions
Copy link

github-actions bot commented Jan 7, 2025

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Jan 7, 2025
@danieldegrasse
Copy link
Contributor

@vishwamartur do you plan to return to this PR? Would be nice to get this issue fixed, and it looks like you just need to removed the required: false from the devicetree binding

@github-actions github-actions bot removed the Stale label Jan 9, 2025
@vishwamartur
Copy link
Author

@danieldegrasse Sure Sir I will work on this next work week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Display driver GC9X01X - Color inversion enabled by default on GC9A01A.

4 participants