sys: util: use BITS_PER_BYTE macro instead of the magic number 8 #80794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfriedt
force-pushed
the
apply-bits-per-byte
branch
3 times, most recently
from
f2652c6 to
efd97c1
Compare
Obviously, everyone knows that there are 8 bits per byte, so there isn't a lot of magic happening, per se, but it's also helpful to clearly denote where the magic number 8 is referring to the number of bits in a byte. Occasionally, 8 will refer to a field size or offset in a structure, MMR, or word. Occasionally, the number 8 will refer to the number of bytes in a 64-bit value (which should probably be replaced with `sizeof(uint64_t)`). For converting bits to bytes, or vice-versa, let's use `BITS_PER_BYTE` for clarity (or other appropriate `BITS_PER_*` macros). Signed-off-by: Chris Friedt <[email protected]>
cfriedt
force-pushed
the
apply-bits-per-byte
branch
from
efd97c1 to
3330055
Compare
cfriedt
changed the title
zephyrbot
requested review from
MarkWangChinese,
andrzej-kaczmarek,
andyross,
ceolin,
danieldegrasse,
dbaluta,
dcpleung,
decsny,
ioannis-karachalios,
jfischer-no,
manuargue,
nashif and
peter-mitsis
jukkar
approved these changes
Nov 4, 2024
jfischer-no
reviewed
Nov 4, 2024
Contributor
jfischer-no
left a comment
jfischer-no
left a comment
There was a problem hiding this comment.
Obviously, everyone knows that there are 8 bits per byte, so
there isn't a lot of magic happening, per se, but it's also
helpful to clearly denote where the magic number 8 is referring
to the number of bits in a byte.
That is an exaggeration. Everyone knows that an octet has eight bits. A byte is not necessarily so.
Member
Author
In this context, byte was used as a synonym for octet. If you feel that isn't necessarily true, please feel free to suggest changes. |
danieldegrasse
approved these changes
Nov 4, 2024
nashif
approved these changes
Nov 8, 2024
peter-mitsis
approved these changes
Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Obviously, everyone knows that there are 8 bits per byte, so there isn't a lot of magic happening, per se, but it's also helpful to clearly denote where the magic number 8 is referring to the number of bits in a byte.
Occasionally, 8 will refer to a field size or offset in a structure, MMR, or word. Occasionally, the number 8 will refer to the number of bytes in a 64-bit value (which should probably be replaced with
sizeof(uint64_t)).For converting bits to bytes, or vice-versa, let's use
BITS_PER_BYTEfor clarity (or other appropriateBITS_PER_*macros).