Skip to content

twister: Fix NOTRUN status #80798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2024
Merged

twister: Fix NOTRUN status #80798

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion scripts/pylib/twister/twisterlib/runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -900,7 +900,9 @@ def process(self, pipeline, done, message, lock, results):
next_op = 'report'
elif self.options.cmake_only:
if self.instance.status == TwisterStatus.NONE:
self.instance.status = TwisterStatus.PASS
logger.debug("CMake only: PASS %s" % self.instance.name)
self.instance.status = TwisterStatus.NOTRUN
self.instance.add_missing_case_status(TwisterStatus.NOTRUN, 'CMake only')
next_op = 'report'
else:
# Here we check the runtime filter results coming from running cmake
Expand Down Expand Up @@ -974,6 +976,10 @@ def process(self, pipeline, done, message, lock, results):
elif self.instance.run and self.instance.handler.ready:
next_op = 'run'
else:
if self.instance.status == TwisterStatus.NOTRUN:
run_conditions = f"(run:{self.instance.run}, handler.ready:{self.instance.handler.ready})"
logger.debug(f"Instance {self.instance.name} can't run {run_conditions}")
self.instance.add_missing_case_status(TwisterStatus.NOTRUN, f"Nowhere to run")
next_op = 'report'
except StatusAttributeError as sae:
logger.error(str(sae))
Expand Down
2 changes: 1 addition & 1 deletion scripts/tests/twister/test_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -978,7 +978,7 @@ def mock_getsize(filename, *args, **kwargs):
mock.ANY,
[],
{'op': 'report', 'test': mock.ANY},
TwisterStatus.PASS,
TwisterStatus.NOTRUN,
mock.ANY,
0,
None
Expand Down
2 changes: 1 addition & 1 deletion scripts/tests/twister_blackbox/test_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ class TestRunner:
os.path.join(TEST_DATA, 'tests', 'dummy', 'agnostic'),
['qemu_x86', 'qemu_x86_64'],
{
'passed_configurations': 6,
'passed_configurations': 0,
'selected_test_instances': 6,
'executed_on_platform': 0,
'only_built': 6,
Expand Down
Loading