Add support ospi driver for Renesas RA8 devices #80799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaoluonguw
requested review from
FRASTM,
KhiemNguyenT,
duynguyenxa and
soburi
|
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
zephyrbot
added
manifest
manifest-hal_renesas
DNM
GeorgeCGV
reviewed
Nov 26, 2024
quytranpzz
force-pushed
the
support_renesas_ra8_ospi
branch
from
8f49aa6 to
ae8e589
Compare
zephyrbot
added
area: Flash
platform: Renesas RA
quytranpzz
force-pushed
the
support_renesas_ra8_ospi
branch
from
ae8e589 to
a585f29
Compare
zephyrbot
removed
manifest
manifest-hal_renesas
DNM
thaoluonguw
force-pushed
the
support_renesas_ra8_ospi
branch
from
a585f29 to
7d172b6
Compare
Contributor
Author
|
Rebase with main to solve conflicts. |
Contributor
Author
|
Hello @GeorgeCGV : Could you please help us review again? Thank you so much. |
GeorgeCGV
reviewed
Jan 10, 2025
GeorgeCGV
reviewed
Jan 10, 2025
GeorgeCGV
reviewed
Jan 10, 2025
GeorgeCGV
reviewed
Jan 10, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the Renesas RA8 OSPI driver across several areas including test configurations, device tree bindings, driver implementation, board support files, and Kconfig updates. Key changes include:
- Adding and updating overlay and configuration files for ek_ra8m1 and ek_ra8d1 boards to support the new OSPI driver.
- Introducing driver and binding files (including new opcodes and transfer structures) for the Renesas RA OSPI NOR flash.
- Updating Kconfig and CMakeLists.txt to integrate the new driver into the build system.
Reviewed Changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/drivers/flash/common/boards/ek_ra8[d1/m1]ospi_b* | Added configuration files and overlays for OSPI NOR flash testing on RA8 boards |
| samples/drivers/spi_flash/src/main.c & samples/drivers/jesd216/src/main.c | Updated samples to recognize the new Renesas RA OSPI NOR flash driver |
| modules/Kconfig.renesas & drivers/flash/Kconfig.renesas_ra_ospi | Added Kconfig entries for the new OSPI driver integration |
| dts/bindings/* | Added new bindings files for OSPI and Flash Controller specific to Renesas RA devices |
| drivers/flash/spi_nor.h & drivers/flash/flash_renesas_ra_ospi_b.h | Introduced opcodes and transfer definitions for the S28Hx512T flash and OSPI transactions |
| boards/renesas/ek_ra8[m1/d1]/*.dts and pinctrl files | Updated board files to enable and configure the new OSPI NOR flash device |
Contributor
|
hi @de-nordic, could you please revisit this PR? |
de-nordic
requested changes
May 20, 2025
drivers/flash/spi_nor.h
Outdated
Comment on lines
64
to
69
| #define SPI_NOR_CMD_WR_WRARG 0x71 /* Write Any Register for S28Hx512T */ | ||
| #define SPI_NOR_CMD_RSFDPID 0x5A /* Read SFDP ID for S28Hx512T */ | ||
| #define SPI_NOR_CMD_RREG 0x65 /* Read Any Register for S28Hx512T */ | ||
| #define SPI_NOR_CMD_SE_256KB 0xDC /* Sector Erase 256KB for S28Hx512T */ | ||
| #define SPI_NOR_CMD_ERCHP 0x60 /* Erase Chip for S28Hx512T */ | ||
|
|
Contributor
There was a problem hiding this comment.
No. it fit his is S28Hx512T specific, it does not land here. Get your own header for that. Specifically that nothing of this is used in spi_nor.c
Contributor
There was a problem hiding this comment.
thank you, I have separated it to another header
drivers/flash/spi_nor.h
Outdated
Comment on lines
85
to
97
| #define SPI_NOR_OCMD_WEN 0x0606 /* Octal Write enable for S28Hx512T */ | ||
| #define SPI_NOR_OCMD_RSR 0x0505 /* Octal Read status register for S28Hx512T */ | ||
| #define SPI_NOR_OCMD_WR_REG2 0x7171 /* Octal Write config register 2 for S28Hx512T */ | ||
| #define SPI_NOR_OCMD_RDID 0x9F9F /* Octal Read JEDEC ID for S28Hx512T */ | ||
| #define SPI_NOR_OCMD_RSFDPID 0x5A5A /* Octal Read SFDP ID for S28Hx512T */ | ||
| #define SPI_NOR_OCMD_RREG 0x6565 /* Octal Read Any Register for S28Hx512T */ | ||
| #define SPI_NOR_OCMD_PP_4B 0x1212 /* Octal Page Program 4 Byte Address for S28Hx512T */ | ||
| #define SPI_NOR_OCMD_READ 0xEEEE /* Octal Read data for S28Hx512T */ | ||
| #define SPI_NOR_OCMD_RST_EN 0x6666 /* Octal Reset Enable for S28Hx512T */ | ||
| #define SPI_NOR_OCMD_RST_MEM 0x9999 /* Reset Memory for S28Hx512T */ | ||
| #define SPI_NOR_OCMD_SE_4KB 0x2121 /* Octal Sector Erase 4Kb address for S28Hx512T */ | ||
| #define SPI_NOR_OCMD_SE_256KB 0xDCDC /* Octal Sector Erase 256Kb address for S28Hx512T */ | ||
| #define SPI_NOR_OCMD_ERCHP 0x6060 /* Octal Erase Chip for S28Hx512T */ |
khoa-nguyen-18
dismissed stale reviews from KhiemNguyenT and thenguyenyf
via
5ea0da0
khoa-nguyen-18
force-pushed
the
support_renesas_ra8_ospi
branch
2 times, most recently
from
5ea0da0 to
bbc2dd5
Compare
Support OSPI flash driver on EK-RA8M1 and EK-RA8D1 with ospi_b and S28HL512T flash. Signed-off-by: Tri Nguyen <[email protected]> Signed-off-by: Thao Luong <[email protected]>
Add ospi node on Renesas RA8 devicetree to support QSPI flash driver Signed-off-by: Quy Tran <[email protected]>
Add support for OSPI flash driver on EK-RA8D1 and EK-RA8M1 Signed-off-by: Quy Tran <[email protected]>
Add support test app "flash/common" for testing Renesas RA OSPI_B on ek_ra8m1, ek_ra8d1 Signed-off-by: Khoa Nguyen <[email protected]>
Add support OSPI for Renesas ek_ra8m1, ek_ra8d1 to run sample jesd216 Signed-off-by: Khoa Nguyen <[email protected]> Signed-off-by: Tri Nguyen <[email protected]> Signed-off-by: Thao Luong <[email protected]>
Add support OSPI for Renesas ek_ra8m1, ek_ra8d1 to run sample spi_flash Signed-off-by: Khoa Nguyen <[email protected]> Signed-off-by: Tri Nguyen <[email protected]> Signed-off-by: Thao Luong <[email protected]>
khoa-nguyen-18
force-pushed
the
support_renesas_ra8_ospi
branch
from
bbc2dd5 to
8fdb94d
Compare
|
Contributor
|
hi @de-nordic, could you please confirm your requested change? |
Contributor
I re-assigning the PR to @KhiemNguyenT as Renesas representative. |
de-nordic
approved these changes
Jun 5, 2025
thenguyenyf
approved these changes
Jun 5, 2025
duynguyenxa
approved these changes
Jun 5, 2025
soburi
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for ospi driver running on Renesas RA8 (RA8M1 and RA8D1)
Note: This PR requires #79766 is merged