Skip to content

Conversation

@rlubos
Copy link
Contributor

@rlubos rlubos commented Nov 4, 2024

If a string is already present in the provided buffer, prometheus_format_exposition() appends it instead of overwriting, hence the buffer needs to be cleared on the test start, otherwise it works by chance.

Fixes #80827

If a string is already present in the provided buffer,
prometheus_format_exposition() appends it instead of overwriting,
hence the buffer needs to be cleared on the test start, otherwise it
works by chance.

Signed-off-by: Robert Lubos <[email protected]>
@zephyrbot zephyrbot added size: XS A PR changing only a single line of code area: Networking labels Nov 4, 2024
Copy link
Contributor

@katgiadla katgiadla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmahadevan108 mmahadevan108 added the bug The issue is a bug, or the PR is fixing a bug label Nov 5, 2024
@mmahadevan108 mmahadevan108 added this to the v4.0.0 milestone Nov 5, 2024
@dkalowsk dkalowsk merged commit a597fea into zephyrproject-rtos:main Nov 6, 2024
24 checks passed
@rlubos rlubos deleted the net/prometheus-formatter-test-fix branch April 24, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: Networking bug The issue is a bug, or the PR is fixing a bug size: XS A PR changing only a single line of code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

net: lib: prometheus: formatter: prometheus.formatter fails

7 participants