Skip to content

Conversation

@sylvioalves
Copy link
Contributor

@sylvioalves sylvioalves commented Nov 5, 2024

Adds notes on Espressif changes to this release.

@sylvioalves sylvioalves marked this pull request as ready for review November 5, 2024 12:48
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kartben This is a variant. Let me know if this is the right place to do so.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine to add, and actually a good idea. Please just keep alphabetical order intact though, and consider indicating the full target name that includes the variant (it's a bit of a mouthful though:))

Copy link
Contributor Author

@sylvioalves sylvioalves Nov 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kartben How do I reference the variant in here? xiao_esp32s3_sense?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xiao_esp32s3/esp32s3/procpu/sense
But maybe it's too long, like I said :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine to add, and actually a good idea. Please just keep alphabetical order intact though, and consider indicating the full target name that includes the variant (it's a bit of a mouthful though:))

@sylvioalves sylvioalves force-pushed the release_notes_v4_01 branch 2 times, most recently from a319e4b to 419ea14 Compare November 5, 2024 20:11
raffarost
raffarost previously approved these changes Nov 5, 2024
wmrsouza
wmrsouza previously approved these changes Nov 5, 2024
uLipe
uLipe previously approved these changes Nov 5, 2024
kartben
kartben previously approved these changes Nov 6, 2024
@sylvioalves
Copy link
Contributor Author

@kartben CI is failing in documentation. I rebased and pushed again to try fixing it.

Update board name to meet zephyr:board model.

Signed-off-by: Sylvio Alves <[email protected]>
Fix typo and re-phrase help description to improve it.

Signed-off-by: Sylvio Alves <[email protected]>
Adds notes on Espressif changes to this release.

Signed-off-by: Sylvio Alves <[email protected]>
@mmahadevan108 mmahadevan108 added this to the v4.0.0 milestone Nov 6, 2024
@mmahadevan108 mmahadevan108 merged commit 85f9940 into zephyrproject-rtos:main Nov 6, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: Documentation platform: ESP32 Espressif ESP32 Release Notes To be mentioned in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants