Skip to content

[Backport v3.7-branch] drivers: ethernet: Fix nxp ethernet due to issue in ksz8081 #80923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 11, 2024
+17 −6
Merged

[Backport v3.7-branch] drivers: ethernet: Fix nxp ethernet due to issue in ksz8081 #80923

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7076559
drivers: ethernet: ksz8081: Fix reset times
Oct 30, 2024
6bddaaa
drivers: ethernet: ksz8081: RMII override RNB part
Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 17 additions & 6 deletions drivers/ethernet/phy/phy_microchip_ksz8081.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,12 @@ LOG_MODULE_REGISTER(LOG_MODULE_NAME);
#define PHY_MC_KSZ8081_OMSO_REG 0x16
#define PHY_MC_KSZ8081_OMSO_FACTORY_MODE_MASK BIT(15)
#define PHY_MC_KSZ8081_OMSO_NAND_TREE_MASK BIT(5)
#define PHY_MC_KSZ8081_OMSO_RMII_OVERRIDE_MASK BIT(1)
#define PHY_MC_KSZ8081_OMSO_MII_OVERRIDE_MASK BIT(0)

#define PHY_MC_KSZ8081_CTRL2_REG 0x1F
#define PHY_MC_KSZ8081_CTRL2_REF_CLK_SEL BIT(7)

#define PHY_MC_KSZ8081_RESET_HOLD_TIME

enum ksz8081_interface {
KSZ8081_MII,
KSZ8081_RMII,
Expand Down Expand Up @@ -237,6 +237,10 @@ static int phy_mc_ksz8081_static_cfg(const struct device *dev)

omso &= ~PHY_MC_KSZ8081_OMSO_FACTORY_MODE_MASK &
~PHY_MC_KSZ8081_OMSO_NAND_TREE_MASK;
if (config->phy_iface == KSZ8081_RMII) {
omso &= ~PHY_MC_KSZ8081_OMSO_MII_OVERRIDE_MASK;
omso |= PHY_MC_KSZ8081_OMSO_RMII_OVERRIDE_MASK;
}

ret = phy_mc_ksz8081_write(dev, PHY_MC_KSZ8081_OMSO_REG, (uint32_t)omso);
if (ret) {
Expand Down Expand Up @@ -289,20 +293,27 @@ static int phy_mc_ksz8081_reset(const struct device *dev)
goto done;
}

/* Wait for 500 ms as specified by datasheet */
k_busy_wait(USEC_PER_MSEC * 500);
/* Wait for at least 500 us as specified by datasheet */
k_busy_wait(1000);

/* Reset over */
ret = gpio_pin_set_dt(&config->reset_gpio, 1);

/* After deasserting reset, must wait at least 100 us to use programming interface */
k_busy_wait(200);

goto done;
skip_reset_gpio:
#endif /* DT_ANY_INST_HAS_PROP_STATUS_OKAY(reset_gpios) */
ret = phy_mc_ksz8081_write(dev, MII_BMCR, MII_BMCR_RESET);
if (ret) {
goto done;
}
/* Wait for 500 ms as specified by datasheet */
k_busy_wait(USEC_PER_MSEC * 500);

/* According to IEEE 802.3, Section 2, Subsection 22.2.4.1.1,
* a PHY reset may take up to 0.5 s.
*/
k_busy_wait(500 * USEC_PER_MSEC);

done:
/* Unlock mutex */
Expand Down
Loading