Skip to content

Conversation

@lyakh
Copy link
Contributor

@lyakh lyakh commented Nov 5, 2024

When CONFIG_LLEXT_STORAGE_WRITABLE is selected and .pre_located is set, the BSS section is allocated by the user too, no need to allocate it internally.

@lyakh
Copy link
Contributor Author

lyakh commented Nov 6, 2024

waiting for thesofproject/sof#9641 to check SOF

@lyakh lyakh marked this pull request as ready for review November 6, 2024 13:16
@zephyrbot zephyrbot added the area: llext Linkable Loadable Extensions label Nov 6, 2024
@zephyrbot zephyrbot requested review from pillo79 and teburd November 6, 2024 13:17
Copy link
Contributor

@pillo79 pillo79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and thanks for this!

EDIT: I would also add a few lines in the Doxygen comments and/or docs mentioning that pre_located now refuses any kind of section allocation, even at the cost of stopping the load process.

When CONFIG_LLEXT_STORAGE_WRITABLE is selected and .pre_located is
set, the BSS section is allocated by the user too, no need to
allocate it internally.

Signed-off-by: Guennadi Liakhovetski <[email protected]>
@nashif nashif merged commit ae8c373 into zephyrproject-rtos:main Nov 16, 2024
23 checks passed
@lyakh lyakh deleted the bss branch November 17, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: llext Linkable Loadable Extensions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants