-
Notifications
You must be signed in to change notification settings - Fork 8.4k
tests: pwm_api: Add timing check #80947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0fafca2 to
bd7988a
Compare
Use GPIO to check PWM output timing. Signed-off-by: Raffael Rostagno <[email protected]>
Update overlay files to add GPIO input for timing checks. Signed-off-by: Raffael Rostagno <[email protected]>
bd7988a to
300d217
Compare
henrikbrixandersen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @henrikbrixandersen, |
Does the chip have another PWM-capture capable peripheral? Producer and consumer does not need to be of the same peripheral type in I'm okay with introducing a GPIO-based PWM loopback test, but I don't think it should be in the main PWM API test suite like this (which is also why I placed the initial loopback test in its own test suite). |
Some Espressif chips only have LEDC and no MCPWM, thus no CC available. The test was meant to be a simple timing check, because we've had some regressions after HAL updates. I can create a separate test suite for it. I'd just need to think how to avoid repeating code, as the 'configs', 'sets' and test sequence would be the same. |
|
@henrikbrixandersen I created a PR for the new implementation (#82258) |
|
should this one be closed in favor of #82258 ? |
Use GPIO interrupts to check PWM output timing.
Depends on #80872