doc: release: add a step to verify that the tag is signed #80962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiobaltieri
requested review from
dkalowsk,
henrikbrixandersen and
mmahadevan108
kartben
previously approved these changes
Nov 6, 2024
henrikbrixandersen
requested changes
Nov 6, 2024
fabiobaltieri
force-pushed
the
release-tag-signed
branch
from
b808acf to
611cd56
Compare
Member
Author
|
Updated to say PGP or SSH, seems reasonable to me for now since both would make the tag looks the same on GitHub, though it may be worth following up on it. |
dkalowsk
reviewed
Nov 6, 2024
fabiobaltieri
force-pushed
the
release-tag-signed
branch
from
611cd56 to
ece4504
Compare
Add an extra "git show" step to the release process to verify that the key has been indeed signed. Signed-off-by: Fabio Baltieri <[email protected]>
fabiobaltieri
force-pushed
the
release-tag-signed
branch
from
ece4504 to
b477efd
Compare
henrikbrixandersen
approved these changes
Nov 6, 2024
dkalowsk
approved these changes
Nov 6, 2024
mmahadevan108
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an extra "git show" step to the release process to verify that the key has been indeed signed.