tests: Bluetooth: ISO: Add validation of broadcast info #80999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rruuaanng
added
area: Bluetooth
area: Tests
Thalley
force-pushed
the
iso_broadcast_info_validation
branch
from
aa512a1 to
e91150e
Compare
Thalley
commented
Nov 6, 2024
include/zephyr/bluetooth/hci_types.h
Outdated
Comment on lines
3351
to
3411
Contributor
Author
There was a problem hiding this comment.
Just in case someone questions the inconsistent prefix; this is what they are called in the BT spec:
Thalley
force-pushed
the
iso_broadcast_info_validation
branch
from
e91150e to
849e439
Compare
Thalley
force-pushed
the
iso_broadcast_info_validation
branch
3 times, most recently
from
e75c3ac to
67f50f7
Compare
Thalley
force-pushed
the
iso_broadcast_info_validation
branch
2 times, most recently
from
a6bf631 to
fa3619a
Compare
Thalley
force-pushed
the
iso_broadcast_info_validation
branch
from
fa3619a to
3628181
Compare
Thalley
force-pushed
the
iso_broadcast_info_validation
branch
from
3628181 to
da33ebf
Compare
Thalley
force-pushed
the
iso_broadcast_info_validation
branch
3 times, most recently
from
0aa6194 to
456e3f9
Compare
zephyrbot
requested review from
alwa-nordic,
cvinayak,
hermabe,
jhedberg,
rugeGerritsen,
sjanc and
theob-pro
Thalley
force-pushed
the
iso_broadcast_info_validation
branch
from
456e3f9 to
1975376
Compare
Thalley
force-pushed
the
iso_broadcast_info_validation
branch
from
1975376 to
08b4bf5
Compare
cvinayak
previously approved these changes
Mar 10, 2025
Thalley
force-pushed
the
iso_broadcast_info_validation
branch
from
08b4bf5 to
63bf7c0
Compare
Contributor
Author
|
Rebased to solve merge conflicts |
cvinayak
approved these changes
Mar 24, 2025
Add validation of the info the application can retrieve by calling bt_iso_chan_get_info. Signed-off-by: Emil Gydesen <[email protected]>
Thalley
force-pushed
the
iso_broadcast_info_validation
branch
from
63bf7c0 to
11c096e
Compare
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (4)
tests/bsim/bluetooth/host/iso/bis/src/bis_receiver.c:98
- [nitpick] Consider adding a descriptive failure message to the assert (e.g., "Expected can_recv to be true") to improve debugging clarity.
TEST_ASSERT(info.can_recv);
tests/bsim/bluetooth/host/iso/bis/src/bis_receiver.c:99
- [nitpick] Consider adding a descriptive failure message to the assert (e.g., "Expected can_send to be false") to improve debugging clarity.
TEST_ASSERT(!info.can_send);
tests/bsim/bluetooth/host/iso/bis/src/bis_broadcaster.c:115
- [nitpick] Consider adding a descriptive failure message to the assert (e.g., "Expected can_recv to be false") to improve debugging clarity.
TEST_ASSERT(!info.can_recv);
tests/bsim/bluetooth/host/iso/bis/src/bis_broadcaster.c:116
- [nitpick] Consider adding a descriptive failure message to the assert (e.g., "Expected can_send to be true") to improve debugging clarity.
TEST_ASSERT(info.can_send);
Contributor
Author
|
@jhedberg can you please review this? |
alwa-nordic
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add validation of the info the application can retrieve by calling bt_iso_chan_get_info.