boards: pico_spe: add support #81003
Conversation
|
Hello @KwsBaer, and thank you very much for your first pull request to the Zephyr project! |
|
|
||
| clocks_default: clocks_default { | ||
| }; |
There was a problem hiding this comment.
| clocks_default: clocks_default { | |
| }; |
|
Do I missed some code changes? |
boards/kws/pico_spe/doc/index.rst
Outdated
| Sample: SPI via PIO | ||
| ==================== | ||
|
|
||
| The :zephyr_file:`samples/sensor/bme280/README.rst` sample includes a |
There was a problem hiding this comment.
| The :zephyr_file:`samples/sensor/bme280/README.rst` sample includes a | |
| The :zephyr:code-sample:`bme280` sample includes a |
There was a problem hiding this comment.
can you please convert this file to the webp format -- that'll make its size twice (if not more) smaller
You may use cwebp CLI or https://tinypng.com/
|
Hi @kartben , |
nordicjm
left a comment
nordicjm
left a comment
There was a problem hiding this comment.
Commits needs sorting and squashed for the board, should be 1x commit for vendor prefix update, 1x commit for board and 1x commit for test update
add of vendor Signed-off-by: Frank Bintakies <[email protected]>
Add variant of rp2040 with SinglePairEthernet Signed-off-by: Frank Bintakies <[email protected]>
|
@nordicjm is my squash and sorting ok? |
| @@ -0,0 +1,10 @@ | |||
| .. _boards-kws: | |||
|
|
|||
| KWS Computersysteme Gmbh | |||
There was a problem hiding this comment.
this can be merged into the other commit
| kosagi Sutajio Ko-Usagi PTE Ltd. | ||
| kvaser Kvaser | ||
| kvg Kverneland Group | ||
| kws KWS Computersysteme Gmbh |
There was a problem hiding this comment.
this file to be taken out into separate commit, before this commit
| io-channels = <&adc 0>, <&adc 1>; | ||
| }; | ||
| }; | ||
|
|
There was a problem hiding this comment.
this to be taken out into a separate commit, after this commit
boards/kws/pico_spe/board.cmake
Outdated
| # The value must be the 'stem' part of the name of one of the files | ||
| # in the openocd interface configuration file. | ||
| # The setting is store to CMakeCache.txt. | ||
| if ("${RPI_PICO_DEBUG_ADAPTER}" STREQUAL "") |
There was a problem hiding this comment.
| if ("${RPI_PICO_DEBUG_ADAPTER}" STREQUAL "") | |
| if("${RPI_PICO_DEBUG_ADAPTER}" STREQUAL "") |
|
|
||
| clocks_default: clocks_default { | ||
| }; |
This reverts commit a5d0f02.
This reverts commit e896319.
add of vendor Signed-off-by: Frank Bintakies <[email protected]>
Add variant of rp2040 with SinglePairEthernet Signed-off-by: Frank Bintakies <[email protected]>
add adc test support Signed-off-by: Frank Bintakies <[email protected]>
6 participants
Add variant of rp2040 with SinglePairEthernet
https://builds.zephyrproject.io/zephyr/pr/81003/docs/boards/index.html#name=spe
https://builds.zephyrproject.io/zephyr/pr/81003/docs/boards/kws/pico_spe/doc/index.html