sensor: Introduce Phosense XBR818 Driver #81013

VynDragon · 2024-11-06T16:34:38Z

This Introduces a driver for the i2c interface of Phosense XBR818.
XBR818 is a 10.525Ghz Radar chip with in-built movement detection algorithm.

jilaypandya

add an entry to the build_all test
https://github.com/zephyrproject-rtos/zephyr/blob/main/tests/drivers/build_all/sensor/i2c.dtsi

drivers/sensor/xbr818/xbr818.c

dts/bindings/sensor/phosense,xbr818.yaml

VynDragon · 2024-11-07T15:45:00Z

add an entry to the build_all test https://github.com/zephyrproject-rtos/zephyr/blob/main/tests/drivers/build_all/sensor/i2c.dtsi

Addressed all the comments, can you confirm what i've added to i2c.dtsi is correct? Thanks.

Edit: I'm not sure what is causing the build failure, the changes I made shouldn't affect this, unless unknown vendor prefix breaks the test (which it shouldnt do knowing the majority of vendors are not in that list and i was told it's only a copy of the linux one, so we cant add to it).

jilaypandya · 2024-11-09T15:12:38Z

(which it shouldnt do knowing the majority of vendors are not in that list and i was told it's only a copy of the linux one, so we cant add to it)

Try adding the vendor name over here
https://github.com/zephyrproject-rtos/zephyr/blob/main/dts/bindings/vendor-prefixes.txt

VynDragon · 2024-11-13T09:24:25Z

Try adding the vendor name over here https://github.com/zephyrproject-rtos/zephyr/blob/main/dts/bindings/vendor-prefixes.txt

Done, but I am concerned it isn't fine, though maybe I misunderstand something.

VynDragon · 2024-11-14T07:40:43Z

check error now is relevant to additional sensor attributes, not sure what to do given this is a pattern that exists in other drivers, maybe I am not doing it how it's supposed to be?

jilaypandya · 2024-11-14T07:49:34Z

give it a try with parenthesis

#define foo (SENSOR_ATTR_PRIV_START + 1 )

jilaypandya

I believe you need to refactor the files in drivers/sensor/<vendor_name>/

VynDragon · 2024-11-15T19:04:20Z

I believe you need to refactor the files in drivers/sensor/<vendor_name>/

I dont think so, looks to be only if there is more than one sensor of the vendor (eg sensor/bosch folder vs sensor/mhz19b or sensor/hp206c for example)

VynDragon · 2024-11-15T19:33:22Z

Found a couple more cases of variable possibly spending longer time on stack than needed so i removed the init at 0 for them too.

VynDragon · 2025-01-27T12:46:42Z

Rebased on latest main.

yperess

One more nit that I missed on the first pass, should be simple enough to update, then I think the driver looks ready.

drivers/sensor/xbr818/xbr818.c

mbolivar · 2025-01-30T19:52:31Z

No objections to the vendor-prefixes.txt change. I don't see anything else for me to review here.

drivers/sensor/xbr818/xbr818.c

kartben · 2025-01-26T08:28:55Z

tests/drivers/build_all/sensor/i2c.dtsi

Suggested change

test_i2c_xbr818: xrb818@aa {

test_i2c_xbr818: xbr818@aa {

kartben · 2025-01-31T20:57:39Z

drivers/sensor/xbr818/xbr818.c

i believe this is actually a violation of our coding guidelines (rule 10.3, casting enum essential type to int essential type). I think the proper solution is:

Suggested change

switch ((int)attr) {

switch ((enum sensor_attribute_xbr818)attr) {

kartben · 2025-01-31T20:59:17Z

drivers/sensor/xbr818/xbr818.c

Suggested change

switch ((int)attr) {

switch ((enum sensor_attribute_xbr818)attr) {

This does not in the other direction this time (SENSOR_ATTR_SAMPLING_FREQUENCY case value '0' not in enumerated type 'enum sensor_attribute_xbr818'

Eh, right 😐
Guess this pattern might be better then

zephyr/drivers/sensor/vishay/veml7700/veml7700.c

Line 412 in 94cd786

if (attr == SENSOR_ATTR_LOWER_THRESH) {

. Definitely more than one driver that's probably non conforming in-tree though...

yperess · 2025-02-07T05:30:37Z

drivers/sensor/xbr818/xbr818.c

Just noticed this, val1 can also be negative, so you should add || val->val1 < 0

yperess · 2025-02-07T05:31:18Z

drivers/sensor/xbr818/xbr818.c

yperess · 2025-02-07T05:33:07Z

drivers/sensor/xbr818/xbr818.c

Can just return xbr818_disable_i2c(dev); here

This Introduces a driver for the i2c interface of Phosense XBR818. XBR818 is a 10.525Ghz Radar chip with builtin detection algorithm. Signed-off-by: Camille BAUD <[email protected]>

rruuaanng

Thank you for taking my advice!

kartben · 2025-02-11T01:19:06Z

@MaureenHelm can you have a look please? PR has gone through quite a few iterations so I'm hopeful it's good to go :)

MaureenHelm · 2025-02-14T01:15:50Z

drivers/sensor/xbr818/xbr818.c

+	return ret;
+}
+
+static const struct sensor_driver_api xbr818_api = {


Suggested change

static const struct sensor_driver_api xbr818_api = {

static DEVICE_API(sensor, xbr818_api) = {

Should I submit a fix commit for this given this was merged before i had the time to update it?

This would be great :)
Given feature freeze is in less than 24 hours I wanted to make sure this got in (and so did @MaureenHelm by not making that comment a blocker)

It is at #85762

zephyrbot added the area: Sensors Sensors label Nov 6, 2024

zephyrbot requested review from MaureenHelm, avisconti, jeppenodgaard, teburd, tristan-google, ubieda and yperess November 6, 2024 16:35

zephyrbot assigned MaureenHelm Nov 6, 2024

jilaypandya reviewed Nov 6, 2024

View reviewed changes

VynDragon force-pushed the xbr818 branch from 8df96d1 to 0ece682 Compare November 7, 2024 15:43

VynDragon force-pushed the xbr818 branch from 0ece682 to f1ad6d4 Compare November 13, 2024 09:23

zephyrbot added the area: Devicetree label Nov 13, 2024

zephyrbot requested review from decsny and galak November 13, 2024 09:24

VynDragon force-pushed the xbr818 branch 2 times, most recently from 2d3bcad to 13b3571 Compare November 15, 2024 18:31

jilaypandya self-requested a review November 15, 2024 18:34

VynDragon force-pushed the xbr818 branch from 13b3571 to dca5ff1 Compare November 15, 2024 18:56

jilaypandya reviewed Nov 15, 2024

View reviewed changes

VynDragon force-pushed the xbr818 branch from dca5ff1 to fef83fc Compare November 15, 2024 19:32

VynDragon force-pushed the xbr818 branch from fef83fc to 1eaf111 Compare November 16, 2024 15:36

VynDragon dismissed yperess’s stale review via c86fa65 January 27, 2025 12:45

VynDragon force-pushed the xbr818 branch 2 times, most recently from c86fa65 to b49ba2b Compare January 27, 2025 12:46

yperess requested changes Jan 27, 2025

View reviewed changes

drivers/sensor/xbr818/xbr818.c Outdated Show resolved Hide resolved

VynDragon force-pushed the xbr818 branch from b49ba2b to 5e1a54f Compare January 30, 2025 19:11

zephyrbot requested a review from mbolivar January 30, 2025 19:11

yperess requested changes Jan 31, 2025

View reviewed changes

drivers/sensor/xbr818/xbr818.c Outdated Show resolved Hide resolved

kartben requested changes Jan 31, 2025

View reviewed changes

VynDragon force-pushed the xbr818 branch 2 times, most recently from 1fb13b3 to 42d4704 Compare February 1, 2025 13:09

VynDragon requested review from kartben and yperess February 2, 2025 11:39

kartben previously approved these changes Feb 2, 2025

View reviewed changes

yperess requested changes Feb 7, 2025

View reviewed changes

sensor: Introduce Phosense XBR818 Driver

0cbbc0e

This Introduces a driver for the i2c interface of Phosense XBR818. XBR818 is a 10.525Ghz Radar chip with builtin detection algorithm. Signed-off-by: Camille BAUD <[email protected]>

VynDragon dismissed kartben’s stale review via 0cbbc0e February 7, 2025 20:58

VynDragon force-pushed the xbr818 branch from 42d4704 to 0cbbc0e Compare February 7, 2025 20:58

VynDragon requested review from kartben and yperess February 7, 2025 22:25

kartben approved these changes Feb 7, 2025

View reviewed changes

rruuaanng approved these changes Feb 8, 2025

View reviewed changes

yperess approved these changes Feb 9, 2025

View reviewed changes

jilaypandya approved these changes Feb 10, 2025

View reviewed changes

MaureenHelm approved these changes Feb 14, 2025

View reviewed changes

kartben merged commit 6376866 into zephyrproject-rtos:main Feb 14, 2025
24 checks passed

VynDragon deleted the xbr818 branch February 14, 2025 16:25

VynDragon mentioned this pull request Mar 10, 2025

Application for role of Collaborator: Camille Baud #86877

Closed

	switch ((int)attr) {
	switch ((enum sensor_attribute_xbr818)attr) {

	static const struct sensor_driver_api xbr818_api = {
	static DEVICE_API(sensor, xbr818_api) = {

sensor: Introduce Phosense XBR818 Driver #81013

sensor: Introduce Phosense XBR818 Driver #81013

Uh oh!

Conversation

VynDragon commented Nov 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jilaypandya left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

VynDragon commented Nov 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jilaypandya commented Nov 9, 2024

Uh oh!

VynDragon commented Nov 13, 2024

Uh oh!

VynDragon commented Nov 14, 2024

Uh oh!

jilaypandya commented Nov 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jilaypandya left a comment

Choose a reason for hiding this comment

Uh oh!

VynDragon commented Nov 15, 2024

Uh oh!

VynDragon commented Nov 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

VynDragon commented Jan 27, 2025

Uh oh!

yperess left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mbolivar commented Jan 30, 2025

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rruuaanng left a comment

Choose a reason for hiding this comment

Uh oh!

kartben commented Feb 11, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

VynDragon commented Nov 6, 2024 •

edited

Loading

VynDragon commented Nov 7, 2024 •

edited

Loading

jilaypandya commented Nov 14, 2024 •

edited

Loading

VynDragon commented Nov 15, 2024 •

edited

Loading