Revert "tinycrypt: deprecate the library"

[ceolin]

This reverts commit 5e225e0.

Based on #79931 and TSC discussions, it was decided that TinyCrypt will be deprecated AFTER 4.0.

[dkalowsk]

...:sigh:...

[valeriosetti]

I agree. #79931 is taking longer than I expected (sorry) and also preceding PRs are still not merged, so it's safer to postpone this. I'll keep working on the deprecation so that it can happen ASAP after 4.0.

[tomi-font]

This is reverting all of #79566, but none of #79653.
#79653 introduced the deprecation of CONFIG_CRYPTO_TINYCRYPT_SHIM. I guess it needs to be reverted as well (dbda464).
Also, the migration guide/release notes entries added in #79653 should be modified so that they don't say things like Following the deprecation of the TinyCrypt library (but rather something like Due to the upcoming deprecation of the TinyCrypt library).

[valeriosetti]

Question: instead of removing all the changes to migration-guide and release-notes, can we keep a warning message on the release-notes stating that

Albeit the formal deprecation of TinyCrypt is not started yet, its removal from the Zephyr codebase is. Formal deprecation should happen soon on the next releases.

This would help users understanding changes like #79653

[dkalowsk]

I agree. #79931 is taking longer than I expected (sorry) and also preceding PRs are still not merged, so it's safer to postpone this. I'll keep working on the deprecation so that it can happen ASAP after 4.0.

@valeriosetti oh no worries, I get this is a tangled mess. Thanks for taking it on!

[mmahadevan108]

@ceolin , can we get this in today?

[nashif]

why is this in draft?

[ceolin]

This is reverting all of #79566, but none of #79653. #79653 introduced the deprecation of CONFIG_CRYPTO_TINYCRYPT_SHIM. I guess it needs to be reverted as well (dbda464). Also, the migration guide/release notes entries added in #79653 should be modified so that they don't say things like Following the deprecation of the TinyCrypt library (but rather something like Due to the upcoming deprecation of the TinyCrypt library).

@tomi-font We don't need to revert those other changes. The crypto driver is its own feature / driver class, we can deprecate it regardless of TinyCrypt. Regarding the release notes about it, I can change to not mention the deprecation but I don't see a reason to do it since it is well known that TinyCrypt deprecation is coming.

[ceolin]

@valeriosetti thanks for checking it. Would you mind take another look ?

[ceolin]

why is this in draft?

my mistake :/

[mmahadevan108]

Marked this as a Blocker as we want to make sure this gets in before we release 4.0

concern addressed/answered

[tomi-font]

This is mostly fine as is, but I think it would still be good to fix the relevant migration guide entries:

• https://github.com/ceolin/zephyr/blob/ceabf44ca8407d3e87a5723e2ad559640b15ba9a/doc/releases/migration-guide-4.0.rst?plain=1#L195
• https://github.com/ceolin/zephyr/blob/ceabf44ca8407d3e87a5723e2ad559640b15ba9a/doc/releases/migration-guide-4.0.rst?plain=1#L573
• https://github.com/ceolin/zephyr/blob/ceabf44ca8407d3e87a5723e2ad559640b15ba9a/doc/releases/migration-guide-4.0.rst?plain=1#L590