drivers: i3c: npcx: i3c target driver #81067
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alvsun
commented
Nov 7, 2024
alvsun
commented
- add buffer mode callback api for DMA.
- add npcx i3c targt driver.
alvsun
force-pushed
the
npcx_i3c_target_drv
branch
from
3ad7c38 to
f7277bf
Compare
alvsun
requested review from
ChiHuaL,
MulinChao,
dcpleung and
ssekar15
as code owners
zephyrbot
added
area: I3C
platform: Nuvoton NPCX
zephyrbot
requested review from
XenuIsWatching,
cyliangtw,
fabiobaltieri,
jackrosenthal,
keith-zephyr and
sjg20
Member
fabiobaltieri
left a comment
fabiobaltieri
left a comment
There was a problem hiding this comment.
hey it looks like second commit has more than just the "add target driver", would it make sense to break it down to smaller changes? it's hard to follow as it is now
XenuIsWatching
requested changes
Nov 9, 2024
alvsun
force-pushed
the
npcx_i3c_target_drv
branch
2 times, most recently
from
e162203 to
a1baedd
Compare
alvsun
force-pushed
the
npcx_i3c_target_drv
branch
from
a1baedd to
39e1aea
Compare
XenuIsWatching
changed the title
alvsun
force-pushed
the
npcx_i3c_target_drv
branch
from
39e1aea to
c77dfb2
Compare
alvsun
force-pushed
the
npcx_i3c_target_drv
branch
from
c77dfb2 to
26920a9
Compare
XenuIsWatching
approved these changes
Nov 20, 2024
XenuIsWatching
approved these changes
Nov 20, 2024
As title. Signed-off-by: Alvis Sun <[email protected]>
As title. Signed-off-by: Alvis Sun <[email protected]>
As title. Signed-off-by: Alvis Sun <[email protected]>
As title. Signed-off-by: Alvis Sun <[email protected]>
alvsun
force-pushed
the
npcx_i3c_target_drv
branch
from
26920a9 to
16d754f
Compare
fabiobaltieri
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.