Skip to content

Conversation

@str4t0m
Copy link
Contributor

@str4t0m str4t0m commented Nov 7, 2024

After the acquisition of Maxim Integrated the documentation of these devices has been moved to the analog.com website. Redirects exist, so they are not broken yet, but we should not rely on that forever.
Therefore the links in the drivers and the sensor sample are updated.

@str4t0m str4t0m marked this pull request as ready for review November 7, 2024 16:07
@zephyrbot zephyrbot added area: Sensors Sensors area: Samples Samples platform: ADI Analog Devices, Inc. area: W1 1-Wire labels Nov 7, 2024
@str4t0m str4t0m added the Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc. label Nov 7, 2024
MaureenHelm
MaureenHelm previously approved these changes Nov 8, 2024
Copy link
Member

@MaureenHelm MaureenHelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kartben kartben removed the Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc. label Nov 8, 2024
Copy link
Contributor

@kartben kartben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: you may want to split URL updates and other Maxim->Analog renames in different commits, or just reword the single commit message so that it's better aligned with the nature of the update (see e.g. some C files where there's no URL being updated, contrary to what the commit message says)

Thanks for this!

Links and the manufacturer name are updated from maxim to analog
for the 1-wire subsystem and the related ds18b20 sensor.

After the acquisition of Maxim Integrated the documentation
of these devices has been moved to the analog.com website.
Redirects exist, so they are not broken yet,
but we should not rely on that.

Signed-off-by: Thomas Stranger <[email protected]>
Links and the manufacturer name are updated from maxim to analog.

After the acquisition of Maxim Integrated the documentation
of these devices has been moved to the analog.com website.
Redirects exist, so they are not broken yet,
but we should not rely on that.

Signed-off-by: Thomas Stranger <[email protected]>
@str4t0m
Copy link
Contributor Author

str4t0m commented Nov 8, 2024

Nit: you may want to split URL updates and other Maxim->Analog renames in different commits, or just reword the single commit message so that it's better aligned with the nature of the update (see e.g. some C files where there's no URL being updated, contrary to what the commit message says)

I started to just update the links, then noticed a few additional things.

I've decided to just update the commit message and additionally split off the changes in the sample into a separate commit. I hope the description is now better reflecting the changes done.

@str4t0m str4t0m changed the title drivers: w1: replace maximintegrated.com links drivers: w1: updates to reflect acquistion of maxim by analog devices Nov 8, 2024
@nashif nashif merged commit e6664e3 into zephyrproject-rtos:main Nov 16, 2024
24 checks passed
@str4t0m str4t0m deleted the w1_links_maxim branch July 28, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: Samples Samples area: Sensors Sensors area: W1 1-Wire platform: ADI Analog Devices, Inc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants