-
Notifications
You must be signed in to change notification settings - Fork 8.4k
doc: espressif: Add missing images #81108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: espressif: Add missing images #81108
Conversation
|
|
kartben
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
Can you please use webp format instead, it will give much smaller files which is important to keep the main git repo size under control. Ideally you even have images with transparent background (which webp supports unlike jpg)
You can use cwebp -resize 600 0 original_image.ext to perform the conversion from the original image (either the ok mage files from this PR or, better, from the actual original / high resolution files you started from)
Thanks again!
88369f9 to
e9b9d05
Compare
kartben
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work - thanks!
Note: ESP8684-DevKitM still missing
|
Also, just opened #81126 since it would have been nice for this PR to trigger CI, except it didn't due to only touching image files. |
Update and add missing Espressif board images. Signed-off-by: Marek Matej <[email protected]>
adding esp8684 + rebase |
fa75ba3
e9b9d05 to
fa75ba3
Compare
yay, a transparent one! :) (which I think the others could be too, btw, since the officials docs seem to have transparent hi-res PNGs that could be used as the source? https://docs.espressif.com/projects/esp-idf/en/v5.0/esp32c3/hw-reference/esp32c3/user-guide-devkitc-02.html) |
Do you want me to replace all the images with the transparent bg ones? |
|
@kartben do you think this could make it to 4.0 release? |
Given that we wouldn't want to update them later since this forever clutters the main git repo, it would be great, yes. But I would also understand if you don't have the energy to do it. |
|
@kartben , can you please approve if this looks fine to you. |
Update and add missing Espressif board images.