Skip to content

Conversation

@jukkar
Copy link
Member

@jukkar jukkar commented Nov 8, 2024

Most of the tests in tests/posix/headers related to networking are already supported so mark them so.
Add implementation to various IPv6 address checking macros we were missing and tests for them.

@jukkar jukkar requested a review from cfriedt November 8, 2024 15:10
@jukkar jukkar added this to the v4.0.0 milestone Nov 8, 2024
@jukkar jukkar added the bug The issue is a bug, or the PR is fixing a bug label Nov 8, 2024
cfriedt
cfriedt previously approved these changes Nov 9, 2024
Copy link
Member

@cfriedt cfriedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pdgendt
pdgendt previously approved these changes Nov 10, 2024
@jukkar jukkar removed this from the v4.0.0 milestone Nov 11, 2024
The Posix documentation uses sin6_scope_id for scope id and
we support that already.

Signed-off-by: Jukka Rissanen <[email protected]>
The in6addr_any is a global symbol that can be used when any
address (all zero bits) is being referenced.

Signed-off-by: Jukka Rissanen <[email protected]>
The IPV6_JOIN/LEAVE_GROUP corresponds to IPV6_ADD/DROP_MEMBERSHIP
definitions so define the former and add tests for them.

Signed-off-by: Jukka Rissanen <[email protected]>
Both the IPV6_UNICAST_HOPS and IPV6_MULTICAST_HOPS are supported
so add tests for them.

Signed-off-by: Jukka Rissanen <[email protected]>
Add INADDR_BROADCAST definition and a test for it.

Signed-off-by: Jukka Rissanen <[email protected]>
Add these Posix specified IPv6 address checking macros

IN6_IS_ADDR_UNSPECIFIED
IN6_IS_ADDR_LOOPBACK
IN6_IS_ADDR_MULTICAST
IN6_IS_ADDR_LINKLOCAL
IN6_IS_ADDR_SITELOCAL
IN6_IS_ADDR_V4MAPPED
IN6_IS_ADDR_MC_NODELOCAL
IN6_IS_ADDR_MC_LINKLOCAL
IN6_IS_ADDR_MC_SITELOCAL
IN6_IS_ADDR_MC_ORGLOCAL
IN6_IS_ADDR_MC_GLOBAL

and tests for them.

Signed-off-by: Jukka Rissanen <[email protected]>
The "struct ipv6_mreq" is supported so enable the tests for it.

Signed-off-by: Jukka Rissanen <[email protected]>
Use zexpect instead of zassert so that the failed tests do not
stop the test execution but we run all the tests.

Signed-off-by: Jukka Rissanen <[email protected]>
@jukkar jukkar dismissed stale reviews from pdgendt and cfriedt via d3e9754 November 11, 2024 11:59
@jukkar jukkar force-pushed the devel/posix-netinet_in.h-additions branch from 87f5819 to d3e9754 Compare November 11, 2024 11:59
@jukkar
Copy link
Member Author

jukkar commented Nov 11, 2024

  • rebased against latest main
  • converted tests to use zexpect instead of zassert

@nashif nashif merged commit 5b00718 into zephyrproject-rtos:main Nov 16, 2024
25 checks passed
@jukkar jukkar deleted the devel/posix-netinet_in.h-additions branch November 17, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: Networking area: POSIX POSIX API Library bug The issue is a bug, or the PR is fixing a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants