linker: llext: avoid modifying current address in linker script snippet #81143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The linker script snippet that places the llext_no_syscall_impl section has the unfortunate side effect of overwriting the current linker address. This can lead to unexpected behavior of the caller script. Saving the current address before defining the section and restoring it afterwards avoids this issue. Fixes zephyrproject-rtos#81136. Signed-off-by: Luca Burelli <[email protected]>
pillo79
added
bug
nashif
approved these changes
Nov 8, 2024
teburd
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The linker script snippet that places the
llext_no_syscall_implsection has the unfortunate side effect of overwriting the current linker address. This can lead to unexpected behavior of the caller script.Saving the current address before defining the section and restoring it afterwards avoids this issue.
Fixes weekly CI issue #81136.