tests: Bluetooth: Audio: Increase RX buf count for bsim #81150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Bluetooth Audio
size: XS
zephyrbot
requested review from
Casper-Bonde-Bose,
MariuszSkamra,
asbjornsabo,
babrsn,
fredrikdanebjer,
jhedberg,
jthm-ot,
kruithofa,
larsgk,
niym-ot,
pin-zephyr and
sjanc
kruithofa
previously approved these changes
Nov 12, 2024
cvinayak
requested changes
Nov 18, 2024
tests/bsim/bluetooth/audio/prj.conf
Outdated
Contributor
There was a problem hiding this comment.
Move the Tx buf count together here.
Suggested change
| CONFIG_BT_ISO_RX_BUF_COUNT=4 | |
| CONFIG_BT_ISO_TX_BUF_COUNT=4 | |
| CONFIG_BT_ISO_RX_BUF_COUNT=4 |
Contributor
Author
There was a problem hiding this comment.
Generally I would rather not change more lines than what's needed.
I would also rather group the Kconfigs by direction, so we get
CONFIG_BT_ISO_TX_MTU=310
CONFIG_BT_ISO_TX_BUF_COUNT=4
CONFIG_BT_ISO_RX_MTU=310
CONFIG_BT_ISO_RX_BUF_COUNT=4
What do you think about that?
The tests were using the default of 1 which is very low, especially when we might have multiple RX streams. Signed-off-by: Emil Gydesen <[email protected]>
Thalley
force-pushed
the
audio_bsim_rx_buf_cnt
branch
from
227cee2 to
a965456
Compare
cvinayak
approved these changes
Nov 19, 2024
kruithofa
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests were using the default of 1 which is very low, especially when we might have multiple RX streams.