boards: nxp: mimxrt1050 align partitions to 256K #81164
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Align the partitions to 256k for mcuboot to handle erase correctly. The datasheet for the S26KS512S claims erases may only be performed on 256 KB sectors. Signed-off-by: David Leach <[email protected]>
zephyrbot
requested review from
DerekSnell,
EmilioCBen,
decsny,
mmahadevan108 and
yvanderv
| storage_partition: partition@700000 { | ||
| label = "storage"; | ||
| reg = <0x0062B000 (DT_SIZE_M(58) - DT_SIZE_K(172))>; | ||
| reg = <0x00700000 DT_SIZE_M(58)>; |
Contributor
There was a problem hiding this comment.
Suggested change
| reg = <0x00700000 DT_SIZE_M(58)>; | |
| reg = <0x00700000 DT_SIZE_M(57)>; |
Since we have increased the MCUBoot sector size to 1M
butok
reviewed
Nov 11, 2024
| boot_partition: partition@0 { | ||
| label = "mcuboot"; | ||
| reg = <0x00000000 DT_SIZE_K(128)>; | ||
| reg = <0x00000000 DT_SIZE_M(1)>; |
Contributor
There was a problem hiding this comment.
Any reason for so high 1 MB size, not 256 KB?
Contributor
|
PR #81335 addresses this issue. I think this can be closed. |
Member
Author
|
#81335 is the proper fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Align the partitions to 256k for mcuboot to handle erase correctly. The datasheet for the S26KS512S claims erases may only be performed on 256 KB sectors.
Fixes #80284