-
Notifications
You must be signed in to change notification settings - Fork 8.3k
drivers: sensor: fcx_mldx5 issue 74761 #81178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3b28c6b to
05f481d
Compare
jeppenodgaard
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
05f481d to
8a8270c
Compare
jeppenodgaard
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First check seems redundant now. Why keep it?
coz one of the values in the array is zero and i think in this case, no memcpy operation shall take place. |
Of course. Thanks for the explanation |
MaureenHelm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please explain in the commit message why you are making this change. It's ok to reference a GitHub Issue number, but that in itself isn't sufficient.
This commit fixes Copy into fixed size buffer (STRING_OVERFLOW) by checking the cmd_data_len Signed-off-by: Jilay Pandya <[email protected]>
8a8270c to
efa4898
Compare
This commit fixes #74761