Skip to content

drivers: serial: stm32: make poll-out function to pass data by value #81179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nashif merged 1 commit into from
Nov 19, 2024
Merged

drivers: serial: stm32: make poll-out function to pass data by value #81179

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions drivers/serial/uart_stm32.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -652,9 +652,9 @@
}

typedef void (*poll_out_fn)(
USART_TypeDef *usart, void *out);
USART_TypeDef *usart, uint16_t out);

Check notice on line 656 in drivers/serial/uart_stm32.c

View workflow job for this annotation

GitHub Actions / Run compliance checks on patch series (PR)

You may want to run clang-format on this change 

drivers/serial/uart_stm32.c:656 
-typedef void (*poll_out_fn)(
-	USART_TypeDef *usart, uint16_t out);
+typedef void (*poll_out_fn)(USART_TypeDef *usart, uint16_t out);
static void uart_stm32_poll_out_visitor(const struct device *dev, void *out, poll_out_fn set_fn)
static void uart_stm32_poll_out_visitor(const struct device *dev, uint16_t out, poll_out_fn set_fn)
{
const struct uart_stm32_config *config = dev->config;
USART_TypeDef *usart = config->usart;
Expand Down Expand Up @@ -707,9 +707,9 @@
*((unsigned char *)in) = (unsigned char)LL_USART_ReceiveData8(usart);
}

static void poll_out_u8(USART_TypeDef *usart, void *out)
static void poll_out_u8(USART_TypeDef *usart, uint16_t out)
{
LL_USART_TransmitData8(usart, *((uint8_t *)out));
LL_USART_TransmitData8(usart, (uint8_t)out);
}

static int uart_stm32_poll_in(const struct device *dev, unsigned char *c)
Expand All @@ -719,14 +719,14 @@

static void uart_stm32_poll_out(const struct device *dev, unsigned char c)
{
uart_stm32_poll_out_visitor(dev, (void *)&c, poll_out_u8);
uart_stm32_poll_out_visitor(dev, c, poll_out_u8);
}

#ifdef CONFIG_UART_WIDE_DATA

static void poll_out_u9(USART_TypeDef *usart, void *out)
static void poll_out_u9(USART_TypeDef *usart, uint16_t out)
{
LL_USART_TransmitData9(usart, *((uint16_t *)out));
LL_USART_TransmitData9(usart, out);
}

static void poll_in_u9(USART_TypeDef *usart, void *in)
Expand All @@ -741,7 +741,7 @@

static void uart_stm32_poll_out_u16(const struct device *dev, uint16_t out_u16)
{
uart_stm32_poll_out_visitor(dev, (void *)&out_u16, poll_out_u9);
uart_stm32_poll_out_visitor(dev, out_u16, poll_out_u9);
}

#endif
Expand Down
Loading