Skip to content

Conversation

@SiliconSignals
Copy link
Contributor

Enable the I2C2 node on the EFM32GG11 SLSTK3701A board

Enable the I2C2 node on the EFM32GG11 SLSTK3701A board

Signed-off-by: Tarang Raval <[email protected]>
@SiliconSignals
Copy link
Contributor Author

logs:

uart:~$ device list
devices:
- gpio@40088400 (READY)
- leuart@4006a000 (READY)
- usart@40011000 (active)
- usart@40010000 (active)
- gpio@40088180 (READY)
- gpio@40088150 (READY)
- gpio@40088120 (READY)
- gpio@400880f0 (READY)
- gpio@400880c0 (READY)
- gpio@40088090 (READY)
- gpio@40088060 (READY)
- gpio@40088030 (READY)
- gpio@40088000 (READY)
- i2c@40089800 (READY)
- i2c@40089400 (READY)
- i2c@40089000 (READY)

@SiliconSignals
Copy link
Contributor Author

Hi @jhedberg,

Thanks for the approval!

I'm not entirely familiar with the process, so could you let me know if there's anything else I need to do after the PR is approved?

@jhedberg
Copy link
Member

I'm not entirely familiar with the process, so could you let me know if there's anything else I need to do after the PR is approved?

There's nothing else you need to do. The Zephyr project is right now in code freeze for Zephyr 4.0, so the PR should get merged after the release is out.

&i2c2 {
pinctrl-0 = <&i2c2_default>;
pinctrl-names = "default";
status = "okay";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not super familiar with devices that must enabled by default, but I believe we have to keep i2c "disabled".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's said, i2c0 and i2c1 are enable. So, I believe this patch is correct.

@nashif nashif merged commit 532c775 into zephyrproject-rtos:main Nov 16, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants