Always check state of CDONE during configuration of iCE40 #81213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turn the assert into an if-statement to ensure that CDONE is always checked during the configuration of an iCE40. Signed-off-by: Benedikt Schmidt <[email protected]>
zephyrbot
requested review from
cfriedt,
fkokosinski,
msierszulski and
tgorochowik
rruuaanng
reviewed
Nov 11, 2024
cfriedt
approved these changes
Nov 11, 2024
rruuaanng
approved these changes
Nov 12, 2024
josuah
approved these changes
Nov 12, 2024
Contributor
josuah
left a comment
josuah
left a comment
There was a problem hiding this comment.
If the RTL image is not valid, then the CDONE would not get toggled.
So an error is better than an assert I agree.
Thank you!
Contributor
Author
|
Even worse, if you for instance reset the wrong output or the FPGA is not connected at all then it obviously never will pull down CDONE. Therefore I think the check is rather essential and should not be only an assert. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turn the assert into an if-statement to ensure that CDONE is always checked during the configuration of an iCE40.