boards: add common configuration for CDC ACM UART #81228
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many boards have similar code to configure the USB and CDC ACM UART that they want to use as a logging or shell backend. Also, many boards have incorrect or incomplete configuration. Remove all USB and CDC ACM configuration in favor of common configuration for all boards and use common board variant to configure CDC ACM UART as backend. Signed-off-by: Johann Fischer <[email protected]>
This was referenced Nov 11, 2024
Contributor
Author
|
Closing in favor of #81308 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many boards have similar code to configure the USB and CDC ACM UART that they want to use as a logging or shell backend. Also, many boards have incorrect or incomplete configuration.
Remove all USB and CDC ACM configuration in favor of common configuration for all boards and use common board variant to configure CDC ACM UART as backend.
This is an alternative for #81220 (but not for snippet changes). It has few drawbacks, there is already a known snippet that is not used here but will contain similar code, probably not usable by out-of-tree boards, confusing as it puts USB-related code under boards/common, requires more work to clean up the boards.