samples: Bluetooth: Handle shutdown of iso broadcast benchmark #81229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Bluetooth
area: Bluetooth ISO
zephyrbot
requested review from
jhedberg,
kartben,
kruithofa,
nashif and
rugeGerritsen
Thalley
force-pushed
the
iso_broadcast_benchmark_stop_fix
branch
from
ee750a8 to
199ec0a
Compare
kruithofa
approved these changes
Nov 18, 2024
Thalley
force-pushed
the
iso_broadcast_benchmark_stop_fix
branch
2 times, most recently
from
d2f0aa5 to
4dfeb00
Compare
The sample did not properly handle ending the broadcast and setting it up for a new broadcast, due to missing wait for sem_big_term and a bad check in iso_disconnected. Furthermore if any did not work when setting up the BIG, the error handling did not properly clean up for a retry. Signed-off-by: Emil Gydesen <[email protected]>
Thalley
force-pushed
the
iso_broadcast_benchmark_stop_fix
branch
from
4dfeb00 to
8148688
Compare
cvinayak
approved these changes
Jan 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sample did not properly handle ending the broadcast and setting it up for a new broadcast, due to missing wait for sem_big_term and a bad check in iso_disconnected.
Furthermore if any did not work when setting up the BIG, the error handling did not properly clean up for a retry.