boards native_sim: Deprecate CONFIG_NATIVE_APPLICATION & CONFIG_NATIVE_SIM_NATIVE_POSIX_COMPAT #81232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aescolar
force-pushed
the
natapp_deprc
branch
from
2ab5499 to
111863c
Compare
aescolar
changed the title
aescolar
force-pushed
the
natapp_deprc
branch
from
111863c to
37f11b0
Compare
17 tasks
zephyrbot
added
Release Notes
zephyrbot
requested review from
dkalowsk,
kartben,
mmahadevan108,
nashif and
tejlmand
18 tasks
kartben
reviewed
Nov 18, 2024
doc/releases/migration-guide-4.1.rst
Outdated
Contributor
There was a problem hiding this comment.
Suggested change
| use anymore on the :kconfig:option:`CONFIG_BOARD_NATIVE_POSIX` option (:github:`81232`). | |
| use the :kconfig:option:`CONFIG_BOARD_NATIVE_POSIX` option anymore (:github:`81232`). |
doc/releases/migration-guide-4.1.rst
Outdated
Comment on lines
116
to
117
Contributor
There was a problem hiding this comment.
Suggested change
| * :kconfig:option:`CONFIG_NATIVE_APPLICATION` has been deprecated. Out of tree boards which | |
| use this option should migrate to use the native_simulator as their runner (:github:`81232`). | |
| * :kconfig:option:`CONFIG_NATIVE_APPLICATION` has been deprecated. Out-of-tree boards using | |
| this option should migrate to the native_simulator runner (:github:81232). |
aescolar
force-pushed
the
natapp_deprc
branch
from
37f11b0 to
39abb6b
Compare
kartben
previously approved these changes
Nov 18, 2024
boards/native/native_sim/Kconfig
Outdated
Contributor
There was a problem hiding this comment.
The Kconfig guidelines state that we should not use default n. I'm fine with leaving it as is
aescolar
force-pushed
the
natapp_deprc
branch
from
39abb6b to
7b26782
Compare
This option is used in tree only by native_posix, which is deprecated and being replaced by native_sim. But may be used also in out of tree targets. As part of the native_posix deprecation, and therefore the lack of testing this feature would have in the future, we are also deprecating this option. Signed-off-by: Alberto Escolar Piedras <[email protected]>
This option existed only to make the transition from native_posix to native_sim easier. As native_posix is going to be removed in v4.2 we deprecate this option now, so it will also be removed. We also switch this option to default to false already now. Signed-off-by: Alberto Escolar Piedras <[email protected]>
aescolar
force-pushed
the
natapp_deprc
branch
from
7b26782 to
3dd95e0
Compare
Mention that CONFIG_NATIVE_APPLICATION & CONFIG_NATIVE_SIM_NATIVE_POSIX_COMPAT have been deprecated. Signed-off-by: Alberto Escolar Piedras <[email protected]>
aescolar
force-pushed
the
natapp_deprc
branch
from
3dd95e0 to
b85382d
Compare
rugeGerritsen
approved these changes
Nov 19, 2024
Member
Author
|
3 new pushes since last:
|
kartben
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
& add to release notes and migration guide