Skip to content

Conversation

@yvanderv
Copy link
Contributor

Adding NXP's contributions to v4.0

@zephyrbot zephyrbot added the Release Notes To be mentioned in the release notes label Nov 11, 2024
@yvanderv yvanderv force-pushed the release-notes-v4.0.0-nxp-contributions branch from 09f8c44 to 56f60ee Compare November 11, 2024 16:57
@JarmouniA JarmouniA added this to the v4.0.0 milestone Nov 11, 2024
decsny
decsny previously requested changes Nov 11, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if this needs to go in the release notes as it isn't exposed to users, it's basically just a refactor of where some code was in the tree

@yvanderv yvanderv force-pushed the release-notes-v4.0.0-nxp-contributions branch 3 times, most recently from 394d15a to 36ec187 Compare November 11, 2024 23:57
@yvanderv
Copy link
Contributor Author

yvanderv commented Nov 12, 2024

@JarmouniA, @decsny, your change suggestions have been integrated. Thanks.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

definitely not something worth mentioning in release notes :) drop the entire change since you're also introducing a duplicated bullet item with "Added two new build ..."

Comment on lines 1337 to 1499
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as before, don't go to the level of details where you're describing changes or tweaks being made to tests (to put it differently: if the release notes are effectively going to the level of detail were it's one bullet point per PR or commit, then we'd rather point users directly to the GitHub interface to see what's new by themselves :) )

@yvanderv yvanderv force-pushed the release-notes-v4.0.0-nxp-contributions branch from 36ec187 to cbbf6b1 Compare November 12, 2024 20:50
@yvanderv yvanderv force-pushed the release-notes-v4.0.0-nxp-contributions branch 2 times, most recently from ed9817a to 9600a29 Compare November 13, 2024 20:25
@yvanderv yvanderv force-pushed the release-notes-v4.0.0-nxp-contributions branch from 9600a29 to de48cf9 Compare November 13, 2024 20:38
@mmahadevan108 mmahadevan108 requested a review from decsny November 14, 2024 16:56
@yvanderv yvanderv force-pushed the release-notes-v4.0.0-nxp-contributions branch from de48cf9 to ffe15d5 Compare November 14, 2024 18:32
@yvanderv yvanderv force-pushed the release-notes-v4.0.0-nxp-contributions branch from ffe15d5 to 6b474c0 Compare November 14, 2024 19:22
Copy link
Contributor

@JarmouniA JarmouniA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yvanderv Looking good, thanks!

@yvanderv yvanderv force-pushed the release-notes-v4.0.0-nxp-contributions branch from 6b474c0 to 77ec768 Compare November 15, 2024 02:30
@yvanderv yvanderv force-pushed the release-notes-v4.0.0-nxp-contributions branch from 77ec768 to 26fd307 Compare November 15, 2024 02:48
@mmahadevan108
Copy link
Contributor

@decsny @kartben , kindly re-visit this PR.

@decsny
Copy link
Member

decsny commented Nov 15, 2024

@decsny @kartben , kindly re-visit this PR.

i reviewed it 10 minutes before this post and my comments still arent addressed, the whole mention of MCXC enablement is missing still for example, and multiple other things still need fixed

@yvanderv
Copy link
Contributor Author

@decsny @kartben , kindly re-visit this PR.

i reviewed it 10 minutes before this post and my comments still arent addressed, the whole mention of MCXC enablement is missing still for example, and multiple other things still need fixed

This has been addressed

@decsny decsny dismissed their stale review November 15, 2024 15:15

do whatever you want

@yvanderv yvanderv force-pushed the release-notes-v4.0.0-nxp-contributions branch from 26fd307 to 9553e0b Compare November 15, 2024 16:09
Adding NXP's contributions to v4.0

Signed-off-by: Yves Vandervennet <[email protected]>
@yvanderv yvanderv force-pushed the release-notes-v4.0.0-nxp-contributions branch from 9553e0b to 5e7a691 Compare November 15, 2024 16:11
@yvanderv
Copy link
Contributor Author

@mmahadevan108 @danieldegrasse @kartben , please review.

* DAC

* DAC API now supports specifying channel path as internal. Support has been added in STM32 drivers.
* Updated the NXP counter_mcux_lptmr driver to support multiple instances of the lptmr
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed this- these look like they should be in the "Counter" section, not DAC

:dtcompatible:`we,wsen-hids-2525020210002` humidity sensor driver.

* Added general samples for triggers
* Added driver for NXP's fxls8974 accelerometer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is already mentioned in the nxp section

* Together with the deprecation of :ref:`native_posix<native_posix>`, many tests which were
explicitly run in native_posix now run in :ref:`native_sim<native_sim>` instead.
native_posix as a platform remains tested though.
* Added documentation (readme) for the erase_blocks flash test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is really not that important

Comment on lines +1502 to +1504
* Extended the tests of counter_basic_api with a testcase for counters wihtout alarms
* Excluded NXP RW612 based boards from the WiFi test suite, as these boards require binary blobs
be downloaded in order to build as expected
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not something for release notes

* Added support for testing SDMMC devices to the fatfs API test
* Extended net/vlan to add IPv6 prefix config to each vlan-iface
* Enhanced the camera fixture test by adding a color bar to enable automation
* Fixed floating point logging issue in the video driver sample code
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds like a really minor change , not sure why this is mentioned?

@kartben
Copy link
Contributor

kartben commented Nov 15, 2024

I will be dismissing my review so that this can be approved by others if they feel this is good enough.

@dleach02
Copy link
Member

Mahesh is going to follow up with a PR to address the last comments

@mmahadevan108 mmahadevan108 merged commit 214837f into zephyrproject-rtos:main Nov 15, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Release Notes To be mentioned in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.