Enhance GPIO hogs for application control and shell commands #81238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to zephyrproject-rtos#55617 Enhance the GPIO hogs driver to allow application control over GPIO configuration and add a shell command for managing GPIOs. * Add `gpio_hogs_configure()` function in `drivers/gpio/gpio_hogs.c` to allow application-controlled GPIO configuration. * Implement logic to filter GPIOs based on the provided port and mask in `gpio_hogs_configure()`. * Modify `gpio_hogs_init()` in `drivers/gpio/gpio_hogs.c` to check the `GPIO_HOGS_INITIALIZE_BY_APPLICATION` Kconfig option. * Update shell commands in `drivers/gpio/gpio_shell.c` to use the `line-names` property for referencing GPIOs by their names. * Add tab completion for GPIO names in the shell commands in `drivers/gpio/gpio_shell.c`. * Add a new Kconfig option `GPIO_HOGS_INITIALIZE_BY_APPLICATION` in `drivers/gpio/Kconfig` to enable application-controlled GPIO initialization. Signed-off-by: Vishwanath Martur <[email protected]>
vishwamartur
force-pushed
the
enhance-gpio-hogs
branch
from
e30941d to
9c7742c
Compare
henrikbrixandersen
requested changes
Nov 11, 2024
Member
henrikbrixandersen
left a comment
henrikbrixandersen
left a comment
There was a problem hiding this comment.
Application-configured GPIO hogs are just... GPIOs. GPIO hogs are intended to be set at boot time, and shouldn't be controlled from the application.
For application-controlled GPIOs, you should introduce a hardware-specific devicetree binding, or use the zephyr,user node as described here: https://docs.zephyrproject.org/latest/build/dts/zephyr-user-node.html#gpios
Member
|
Closing as per comment #81238 (review) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #55617
Enhance the GPIO hogs driver to allow application control over GPIO configuration and add a shell command for managing GPIOs.
gpio_hogs_configure()function indrivers/gpio/gpio_hogs.cto allow application-controlled GPIO configuration.gpio_hogs_configure().gpio_hogs_init()indrivers/gpio/gpio_hogs.cto check theGPIO_HOGS_INITIALIZE_BY_APPLICATIONKconfig option.drivers/gpio/gpio_shell.cto use theline-namesproperty for referencing GPIOs by their names.drivers/gpio/gpio_shell.c.GPIO_HOGS_INITIALIZE_BY_APPLICATIONindrivers/gpio/Kconfigto enable application-controlled GPIO initialization.