Bluetooth: BAP: BA: Add validation of add/mod src #81275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thalley
force-pushed
the
bap_broadcast_assistant_param_valid
branch
2 times, most recently
from
9f8ed51 to
58e14e9
Compare
zephyrbot
requested review from
Casper-Bonde-Bose,
MariuszSkamra,
asbjornsabo,
babrsn,
fredrikdanebjer,
jhedberg,
jthm-ot,
kruithofa,
larsgk,
niym-ot,
pin-zephyr and
sjanc
kruithofa
approved these changes
Nov 18, 2024
Thalley
force-pushed
the
bap_broadcast_assistant_param_valid
branch
from
58e14e9 to
0e5dc24
Compare
The functions did not verify the provided parameters before sending it as a control point operation. This also fixes a bug where BT_BAP_BIS_SYNC_NO_PREF was not allowed when pa_sync=0. Signed-off-by: Emil Gydesen <[email protected]>
Thalley
force-pushed
the
bap_broadcast_assistant_param_valid
branch
from
0e5dc24 to
5fe6393
Compare
larsgk
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functions did not verify the provided parameters before sending it as a control point operation.
This also fixes a bug where BT_BAP_BIS_SYNC_NO_PREF was not allowed when pa_sync=0.
fixes #79601