LE Audio: Use depends on instead of select
#81328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thalley
changed the title
depends on instead of select
Thalley
force-pushed
the
bap_kconfig_updates
branch
7 times, most recently
from
6ab2700 to
7cba91e
Compare
Remove the selects from BT_BAP_UNICAST_SERVER and BT_BAP_UNICAST_CLIENT and use a def_bool for BT_BAP_UNICAST. This is part of an effort to reduce select in Kconfig. Signed-off-by: Emil Gydesen <[email protected]>
Modify the Kconfig options to depend on the GATT features rather than selecting them. This is part of an effort to reduce the amount of selects we use in LE Audio. Signed-off-by: Emil Gydesen <[email protected]>
Remove the selects and use def_bool for BT_AUDIO_RX and BT_AUDIO_TX. This is part of an effort to reduce select in Kconfig. Signed-off-by: Emil Gydesen <[email protected]>
The BAP_BROADCAST_SOURCE Kconfig option now depends on BT_ISO_BROADCASTER instead of selecting it. This is an effort to reduce the use of select in LE Audio. Signed-off-by: Emil Gydesen <[email protected]>
Thalley
force-pushed
the
bap_kconfig_updates
branch
from
7cba91e to
36d2522
Compare
The BAP Kconfigs option now depends on BT_ISO_BROADCASTER instead of selecting it. This is an effort to reduce the use of select in LE Audio. Signed-off-by: Emil Gydesen <[email protected]>
Modify ASCS and BAP Broadcast sink to depend on the PAC options
instead of selecting them.
Since Kconfig does not support "depends on X if Y",
a select for PAC_{SRC,SNK} is used depending on
ASCS_ASE_{SRC,SNK}.
Signed-off-by: Emil Gydesen <[email protected]>
Change the select of BT_PER_ADV_SYNC and BT_EXT_ADV to depends on. This is an effort to reduce the use of select for Kconfig options. Signed-off-by: Emil Gydesen <[email protected]>
Change the select to a depends on for the Kconfig options for HAS and HAS_CLIENT. This is an effort to reduce the number of selects used by LE Audio. Signed-off-by: Emil Gydesen <[email protected]>
Add the list of affect Kconfig options to the migration guide. Signed-off-by: Emil Gydesen <[email protected]>
Thalley
force-pushed
the
bap_kconfig_updates
branch
from
36d2522 to
c97d719
Compare
zephyrbot
added
area: Bluetooth Audio
area: Samples
zephyrbot
requested review from
Casper-Bonde-Bose,
asbjornsabo,
babrsn and
dkalowsk
zephyrbot
requested review from
MariuszSkamra,
fredrikdanebjer,
jhedberg,
jthm-ot,
kartben,
kruithofa,
larsgk,
nashif,
niym-ot,
pin-zephyr and
sjanc
jhedberg
approved these changes
Nov 18, 2024
kartben
approved these changes
Nov 18, 2024
babrsn
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #72559