west.yml: espressif: fix mcuboot assert in hal #81352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
LucasTambor,
marekmatej,
raffarost,
uLipe and
wmrsouza
Espressif contains mcuboot calls for loading image. This fixes the way assert call is included in that scenario. Fixes zephyrproject-rtos#81351 Signed-off-by: Sylvio Alves <[email protected]>
sylvioalves
force-pushed
the
bugfix/mcuboot_assert
branch
from
b5aed1b to
965df39
Compare
|
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
zephyrbot
added
manifest
manifest-hal_espressif
size: XS
| groups: | ||
| - hal | ||
| - name: hal_espressif | ||
| revision: 174547ef6a97dafcd6786ecd171cc701f5c0893b |
Contributor
There was a problem hiding this comment.
This change is pulling in a few more intermediate commits that were added prior to the assert fix.
If we need this for 4.0, how can we limit the risk?
Contributor
Author
There was a problem hiding this comment.
@mmahadevan108 I added in the PR description that the hal update includes an additional commit as you also mentioned. Both changes have been tested and confirmed to fix the reported issue.
raffarost
approved these changes
Nov 13, 2024
wmrsouza
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Espressif contains mcuboot calls for loading image. This fixes the way assert call is included in that scenario.
This also includes in HAL a commit addressing an ESP32-C2 Wi-Fi connection issue related to rom functions.
Fixes #81351