scripts: west_commands: core: run netcat with check_call() #81356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfriedt
force-pushed
the
west-commands-core-run-telnet-client-ignores-ctrl-c
branch
from
b6a640b to
f2ca049
Compare
Netcat (nc) does not handle SIGINT. It silently ignores it. We cannot use run_client(), given that the pydoc for run_client() specifically contains "Run a client that handles SIGINT". Instead, use check_call(), which correctly handles Ctrl+C. Signed-off-by: Chris Friedt <[email protected]>
cfriedt
force-pushed
the
west-commands-core-run-telnet-client-ignores-ctrl-c
branch
from
f2ca049 to
4fa55fb
Compare
zephyrbot
requested review from
carlescufi,
mbolivar-ampere,
pdgendt and
swinslow
pdgendt
approved these changes
Nov 14, 2024
de-nordic
approved these changes
Nov 18, 2024
thedjnK
approved these changes
Nov 18, 2024
de-nordic
added
the
Trivial
dkalowsk
approved these changes
Nov 18, 2024
cfriedt
deleted the
west-commands-core-run-telnet-client-ignores-ctrl-c
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Netcat (nc) does not handle SIGINT. It silently ignores it. This is problematic, because several orphaned processes can be left behind, preventing subsequent invocations of
twisterorwestfrom succeeding, until orphaned processes are manually killed.We cannot use
run_client(), given that the pydoc forrun_client()specifically contains "Run a client that handles SIGINT".Instead, use
check_call(), which correctly handlesCtrl+C.Fixes #81194