logging: Add a log flush operation #81360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pillo79
previously approved these changes
Nov 14, 2024
Contributor
pillo79
left a comment
pillo79
left a comment
There was a problem hiding this comment.
Thanks, looks like a proper fix for the issue! 🚀
2 minor suggestions if you wish to address those.
include/zephyr/logging/log_ctrl.h
Outdated
Contributor
There was a problem hiding this comment.
It should be possible to define log_flush as a syscall, to allow userspace to use it as well, not necessarily with LLEXT 🙂
nordic-krch
reviewed
Nov 14, 2024
teburd
force-pushed
the
log_flush_llext
branch
from
3c4c58f to
d5c4ee8
Compare
zephyrbot
requested review from
aaronemassey,
asemjonovs,
jeremybettis,
nashif and
yperess
teburd
force-pushed
the
log_flush_llext
branch
4 times, most recently
from
b77f887 to
431a2f0
Compare
teburd
force-pushed
the
log_flush_llext
branch
from
431a2f0 to
6b39234
Compare
teburd
force-pushed
the
log_flush_llext
branch
from
6b39234 to
b78c909
Compare
nordic-krch
reviewed
Jan 10, 2025
lyakh
previously approved these changes
Jan 13, 2025
Ensure all pending log messages are processed by the log processing thread when log_flush is called, blocking the caller until done. Signed-off-by: Tom Burdick <[email protected]>
teburd
force-pushed
the
log_flush_llext
branch
from
b78c909 to
f42b7fb
Compare
nordic-krch
approved these changes
Jan 15, 2025
kartben
approved these changes
Jan 15, 2025
lyakh
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure all pending log messages are processed by the log processing thread when log_flush is called, blocking the caller until done.
#81350 might be fixed by this, need @lyakh to confirm