usb: shell: Remove use of ctx_shell #81395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ctx_shell was only used a single place and in a function that already has a `sh` that would be better to use. Signed-off-by: Emil Gydesen <[email protected]>
Contributor
Author
I always keep PRs in draft until they reach their first CI pass :) |
tmon-nordic
approved these changes
Nov 14, 2024
henrikbrixandersen
approved these changes
Nov 19, 2024
Contributor
Author
|
@jfischer-no please review :) |
kartben
approved these changes
Nov 26, 2024
jfischer-no
approved these changes
Nov 26, 2024
Contributor
jfischer-no
left a comment
jfischer-no
left a comment
There was a problem hiding this comment.
okay, although I have to bring it back soon.
Contributor
Author
:( In BT we have #74652 as a step forward to eliminating it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ctx_shell was only used a single place and in a function that already has a
shthat would be better to use.