drivers: adc: fix mV conversion error with high resolution ADC data #81398
Conversation
|
fixes #81363 |
Fix the overflow encountered with too high resolution ADC output data when using adc_raw_to_millivolts. This is done by using int64_t instead of a int32_t for the internal computations. Signed-off-by: Johan Lafon <[email protected]>
|
It seems there is no test suite or in-tree use of this API? I would expect the API change to break something? if there is not even a test suite testing the API, could you add one? |
|
also, is this ready for review? its in draft :) |
|
There is actually tests that use adc_raw_to_millivolts/adc_raw_to_millivolts_dt. I did not changed these function signature, so the tests did not broke. This PR is in draft because I'm not sure this should be the preferred solution, hence the issue I have opened here : #81363. |
|
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
4 participants
Fix the overflow encountered with too high resolution ADC output data when using adc_raw_to_millivolts. This is done by using int64_t instead of a int32_t for the internal computations.