boards nrf52_bsim: Fix sample used as example #81413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's fix the sample used in the example. The peripheral_hr and central_hr are meant to be run with each other. Let's also use the :zephyr:code-sample: directive to refer to the samples so we get a link. Signed-off-by: Alberto Escolar Piedras <[email protected]>
iduhetonas
approved these changes
Nov 14, 2024
iduhetonas
left a comment
iduhetonas
left a comment
There was a problem hiding this comment.
Fantastic, this was exactly what I tested.
kartben
approved these changes
Nov 14, 2024
rugeGerritsen
approved these changes
Nov 14, 2024
aescolar
added
the
Trivial
Member
Author
|
@dkalowsk @mmahadevan108 I just tagged this for 4.0 and as trivial so it could make it for today if you guys consider it is worthwhile. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's fix the sample used in the example. The peripheral_hr and central_hr are meant to be run with each other. Let's also use the :zephyr:code-sample: directive to refer to the samples so we get a link.
Fixes #81412