modules: hal_nordic: nrfs: Enqueue requests when not connected #81422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lstnl
reviewed
Nov 15, 2024
Allow `nrfs_backend_send` to push early requests into the message queue, but defer sending them until a connection is established, at which point the queue will be flushed. This benefits asynchronous code by making it optional to call `nrfs_backend_wait_for_connection` before using the nrfs service API, which is already non-blocking. Signed-off-by: Grzegorz Swiderski <[email protected]>
57300
force-pushed
the
nrfs-early-send
branch
from
4f558f3 to
398f183
Compare
zephyrbot
requested review from
anangl,
hubertmis,
krish2718,
nordic-krch and
sachinthegreen
lstnl
approved these changes
Nov 18, 2024
anangl
approved these changes
Nov 19, 2024
nordic-krch
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow
nrfs_backend_sendto push early requests into the message queue, but defer sending them until a connection is established, at which point the queue will be flushed. This benefits asynchronous code by making it optional to callnrfs_backend_wait_for_connectionbefore using the nrfs service API, which is already non-blocking.