Bluetooth: host: Fix bug in disconnected handling #81433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When disconnected only the first empty slot in the disconnected_handles array should be updated. Signed-off-by: Jens Rehhoff Thomsen <[email protected]>
zephyrbot
added
area: Bluetooth Host
zephyrbot
requested review from
alwa-nordic,
hermabe,
rugeGerritsen,
sjanc and
theob-pro
jhedberg
approved these changes
Nov 15, 2024
Contributor
|
Can we add a test for this code path? |
Thalley
approved these changes
Nov 15, 2024
Comment on lines
+936
to
+937
|
|
||
| return; |
Contributor
There was a problem hiding this comment.
For semantic reasons I'd just add a break instead of return, but the result will be the same
Contributor
Worth a test-case, but shouldn't be a requirement for merging this fix. |
Contributor
I was thinking the same. It requires not only triggering the issue, but also somehow verifying the correctness. Wouldn't be too hard to do with a unit test though I believe |
alwa-nordic
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When disconnected only the first empty slot in the disconnected_handles array should be updated.