drivers: ethernet: w5500: streamline codebase #81462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change marks `w5500_api_funcs`, an instance of the `ethernet_api`, as `const`. By using `const`, we ensure immutability, leading to usage of only `.rodata` and a reduction in the `.data` area. Signed-off-by: Pisit Sawangvonganan <[email protected]>
Improve type safety and consistency by adjusting variable and parameter types to avoid signed/unsigned comparisons and implicit casts. Moreover, explicit casts were applied when converting from `size_t` to `uint16_t`. Signed-off-by: Pisit Sawangvonganan <[email protected]>
pdgendt
approved these changes
Nov 19, 2024
mniestroj
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes 2 changes as follows:
w5500_api_funcsstructureconstto indicate that it should not be modified.lenparameter.