Skip to content

soc: nxp: imxrt11xx: select CONFIG_HAS_MCUX_ADC_ETC #81467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kartben merged 1 commit into from
Dec 7, 2024
Merged

soc: nxp: imxrt11xx: select CONFIG_HAS_MCUX_ADC_ETC #81467

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions drivers/adc/Kconfig.mcux
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,13 @@ config ADC_MCUX_LPADC
help
Enable the MCUX LPADC driver.

if ADC_MCUX_12B1MSPS_SAR || ADC_MCUX_LPADC
config ADC_MCUX_ETC
bool "MCUX ADC ETC driver"
depends on HAS_MCUX_ADC_ETC
help
Enable the MCUX ADC ETC driver.
endif
Comment on lines +40 to +46
Copy link
Member

@decsny decsny Dec 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if ADC_MCUX_12B1MSPS_SAR || ADC_MCUX_LPADC
config ADC_MCUX_ETC
bool "MCUX ADC ETC driver"
depends on HAS_MCUX_ADC_ETC
help
Enable the MCUX ADC ETC driver.
endif
config ADC_MCUX_ETC
bool "MCUX ADC ETC driver"
depends on DT_HAS_NXP_ADC_ETC_ENABLED
help
Enable the MCUX ADC ETC driver.

and then just make a one-line binding file with the compat string, and add a small node to rt11xx.dtsi and rt10xx.dtsi that just looks like this basically:

adc_etc@deadbeef {
    compatible = "nxp,adc-etc";
};

can just leave status okay in soc level since the kconfig is n by default, if dont want to change all the board dts

Copy link
Contributor Author

@Raymond0225 Raymond0225 Dec 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why remove "if ADC_MCUX_12B1MSPS_SAR || ADC_MCUX_LPAD"? ETC can not work standalone


config ADC_MCUX_GAU
bool "MCUX GAU ADC driver"
Expand Down
1 change: 1 addition & 0 deletions soc/nxp/imxrt/imxrt11xx/Kconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ config SOC_SERIES_IMXRT11XX
select HAS_MCUX_LPI2C
select HAS_MCUX_LPSPI
select HAS_MCUX_LPADC
select HAS_MCUX_ADC_ETC
select HAS_MCUX_LPUART
select HAS_MCUX_ELCDIF
select HAS_MCUX_MIPI_DSI
Expand Down
Loading