tests: thread_error_case and ztest/base: fix incorrect userspace filtering #81469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The filter here should be used to filter for capability: whether the platform configuration supports userspace. And if it does support userspace, we then enable CONFIG_TEST_USERSPACE (and thus CONFIG_USERSPACE) for testing. We should not be filtering for whether userspace is enabled, but should really be filtering for whether userspace is supported. Signed-off-by: Daniel Leung <[email protected]>
The filter here should be used to filter for capability: whether the platform configuration supports userspace. And if it does support userspace, we then enable CONFIG_TEST_USERSPACE (and thus CONFIG_USERSPACE) for testing. We should not be filtering for whether userspace is enabled, but should really be filtering for whether userspace is supported. Signed-off-by: Daniel Leung <[email protected]>
zephyrbot
requested review from
TaiJuWu,
aaronemassey,
andyross,
asemjonovs,
ceolin,
cfriedt,
jeremybettis,
nashif,
npitre,
peter-mitsis and
yperess
andyross
approved these changes
Nov 18, 2024
cfriedt
approved these changes
Nov 18, 2024
nashif
approved these changes
Nov 18, 2024
peter-mitsis
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The filter here should be used to filter for capability: whether the platform configuration supports userspace. And if it does support userspace, we then enable CONFIG_TEST_USERSPACE (and thus CONFIG_USERSPACE) for testing. We should not be filtering for whether userspace is enabled, but should really be filtering for whether userspace is supported.