Skip to content

dts: bindings: timer: move a few counter bindings to correct location #81473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nashif merged 1 commit into from
Nov 19, 2024
Merged

dts: bindings: timer: move a few counter bindings to correct location #81473

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 dts/bindings/timer/andestech,atcpit100.yaml → ...bindings/counter/andestech,atcpit100.yaml
View file
Open in desktop
File renamed without changes.
0 dts/bindings/timer/arm,cmsdk-dtimer.yaml → dts/bindings/counter/arm,cmsdk-dtimer.yaml
View file
Open in desktop
File renamed without changes.
0 dts/bindings/timer/arm,cmsdk-timer.yaml → dts/bindings/counter/arm,cmsdk-timer.yaml
View file
Open in desktop
File renamed without changes.
0 dts/bindings/timer/atmel,sam-tc.yaml → dts/bindings/counter/atmel,sam-tc.yaml
View file
Open in desktop
File renamed without changes.
0 dts/bindings/timer/atmel,sam0-tc32.yaml → dts/bindings/counter/atmel,sam0-tc32.yaml
View file
Open in desktop
File renamed without changes.
0 dts/bindings/timer/gd,gd32-timer.yaml → dts/bindings/counter/gd,gd32-timer.yaml
View file
Open in desktop
File renamed without changes.
0 dts/bindings/timer/nordic,nrf-timer.yaml → dts/bindings/counter/nordic,nrf-timer.yaml
View file
Open in desktop
File renamed without changes.
0 dts/bindings/timer/nxp,lpc-ctimer.yaml → dts/bindings/counter/nxp,lpc-ctimer.yaml
View file
Open in desktop
File renamed without changes.
0 dts/bindings/timer/nxp,s32-sys-timer.yaml → dts/bindings/counter/nxp,s32-sys-timer.yaml
View file
Open in desktop
Copy link
Member

@manuargue manuargue Nov 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with the change, but what would be the right place for hw timers that could be used either as a system timer or as a counter? perhaps the binding is defined in one place and the other binding inherits from it?
Currently there's only a counter driver for this hw counter, but in the future we may introduce a system timer driver as well.

Copy link
Contributor Author

@danieldegrasse danieldegrasse Nov 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a good question. Personally, I would lean towards the timer folder, but I am not sure if it matters too much. The reason for this PR was that I got myself confused when looking at some counter drivers, and assumed they were timer drivers because of their binding location.

@decsny any preference here?

File renamed without changes.
0 dts/bindings/timer/nxp,tpm-timer.yaml → dts/bindings/counter/nxp,tpm-timer.yaml
View file
Open in desktop
File renamed without changes.
0 ...indings/timer/raspberrypi,pico-timer.yaml → ...dings/counter/raspberrypi,pico-timer.yaml
View file
Open in desktop
File renamed without changes.
0 ...ndings/timer/renesas,smartbond-timer.yaml → ...ings/counter/renesas,smartbond-timer.yaml
View file
Open in desktop
File renamed without changes.
Loading