drivers: stepper: refactor common registers to tmc5xxx #81484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jilaypandya
force-pushed
the
feature/tmc5xxx-common-macros
branch
from
0ece588 to
f55791a
Compare
This commit generalizes macros which are common to tmc5xxx drivers Signed-off-by: Jilay Pandya <[email protected]>
This commit refactors tmc5041 driver to use tmc5xxx generalized macros Signed-off-by: Jilay Pandya <[email protected]>
jilaypandya
force-pushed
the
feature/tmc5xxx-common-macros
branch
from
f55791a to
dba952e
Compare
jilaypandya
requested review from
bjarki-andreasen,
dipakgmx,
fabiobaltieri and
faxe1008
fabiobaltieri
approved these changes
Nov 17, 2024
faxe1008
approved these changes
Nov 18, 2024
dipakgmx
approved these changes
Nov 18, 2024
fabiobaltieri
added
the
Trivial
kartben
approved these changes
Nov 19, 2024
bjarki-andreasen
approved these changes
Nov 19, 2024
Contributor
bjarki-andreasen
left a comment
bjarki-andreasen
left a comment
There was a problem hiding this comment.
I would have preferred this being one commit, since seemingly the first commit is incompatible with the driver, which is then adapted in the second commit :)
Member
Author
That's correct. Thanks for pointing it out. I'll keep this in mind next time :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors common register values to tmc5xxx.
This PR facilitates #80784 .