drivers: led: lp5569: implement write_channels api

[Emil-Juhl]

drivers: led: lp5569: enable auto-increment

The lp5569 controller supports auto-increment for its registers. This is by
default enabled in the chip, but the driver actively disabled it.

Since auto-increment is useful for writing multiple consecutive registers,
enable the feature. The driver, however, doesn't perform such consecutive
writes and thus the existing behavior is not altered.

Signed-off-by: Emil Dahl Juhl [email protected]

drivers: led: lp5569: implement write_channels api

The lp5569 has multiple pwm outputs, and thus implementing the
write_channels api to set multiple values in a single call makes sense.

Implement the write_channels function with a basic range check on the
channel range.
Since the lp5569 supports auto-increment, all of the channels can be
written in one i2c transfer, starting from the pwm register of the
start_channel.

Signed-off-by: Emil Dahl Juhl [email protected]

[jonas-rem]

Could you also adapt the test for the driver so that this feature is used there? Some of the other tests for the led drivers already test the write_channels function.

[Emil-Juhl]

Could you also adapt the test for the driver so that this feature is used there?

I haven't been able to find any existing test for the ti,lp5569 except for tests/drivers/build_all/led/src/main.c which does essentially nothing.
Could I ask you to point me to the testcode that you refer to? Thanks!

Some of the other tests for the led drivers already test the write_channels function.

Do you have a reference on that - again I wasn't really able to find anything. Though for this one, the led-api test, tests/drivers/led/led_api/src/test_led_api.c, seems relevant. It doesn't excercise the write_channels api though, but it could be extended to do so I guess. Is that, what you're going for?

[jonas-rem]

Could you also adapt the test for the driver so that this feature is used there?

I haven't been able to find any existing test for the ti,lp5569 except for tests/drivers/build_all/led/src/main.c which does essentially nothing. Could I ask you to point me to the testcode that you refer to? Thanks!

Some of the other tests for the led drivers already test the write_channels function.

Do you have a reference on that - again I wasn't really able to find anything. Though for this one, the led-api test, tests/drivers/led/led_api/src/test_led_api.c, seems relevant. It doesn't excercise the write_channels api though, but it could be extended to do so I guess. Is that, what you're going for?

Oh, it's not a test but a sample. You can find the sample for the lp5569 here:

samples/drivers/led/lp5569/

And for the other led drivers in the same head folder:

ls samples/drivers/led/
apa102c_bitbang  is31fl3194   is31fl3733  lp3943  lp5562  pca9633  sx1509b_intensity
index.rst        is31fl3216a  led_strip   lp50xx  lp5569  pwm      xec

[Emil-Juhl]

Oh, it's not a test but a sample. You can find the sample for the lp5569 here:

samples/drivers/led/lp5569/

Thank you!
I've added usage of the led_write_channels api in 8365651
If this is not what you had in mind, let me know and we'll work it out :)

[jonas-rem]

Oh, it's not a test but a sample. You can find the sample for the lp5569 here:
samples/drivers/led/lp5569/

Thank you! I've added usage of the led_write_channels api in 8365651 If this is not what you had in mind, let me know and we'll work it out :)

Thanks! I think this is sufficient to demonstrate. I have a board with two lp5569 here and will test later today.

[simonguinot]

Hello @Emil-Juhl,

Thanks for implementing the write_channels() API for the lp5569 driver. It is clear and straightforward.

See below for the changes I am requesting.

[Emil-Juhl]

@simonguinot Thanks for the comments, I've resolved the conversations - but if you don't think I've resolved the issues appropriately, just re-open them and let me know.

[simonguinot]

Thanks @Emil-Juhl !