Skip to content

Conversation

@brycewilkins
Copy link
Contributor

@brycewilkins brycewilkins commented Nov 29, 2024

Update segger module to zephyrproject-rtos/segger#22
.

@zephyrbot
Copy link

zephyrbot commented Nov 29, 2024

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
segger zephyrproject-rtos/segger@1a607e8 zephyrproject-rtos/segger@cf56b1d (master) zephyrproject-rtos/[email protected]

All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@zephyrbot zephyrbot added manifest manifest-segger DNM This PR should not be merged (Do Not Merge) labels Nov 29, 2024
@brycewilkins brycewilkins force-pushed the bw/manifest_segger_update branch from bf11223 to fe15d8f Compare November 29, 2024 19:48
@brycewilkins brycewilkins marked this pull request as ready for review December 7, 2024 17:41
@zephyrbot zephyrbot requested a review from nordic-krch December 7, 2024 17:41
kartben
kartben previously approved these changes Dec 16, 2024
@kartben
Copy link
Contributor

kartben commented Dec 17, 2024

Module repo PR has been merged

@brycewilkins brycewilkins force-pushed the bw/manifest_segger_update branch from f68c374 to fe15d8f Compare December 17, 2024 13:50
Fix typos.

Signed-off-by: Bryce Wilkins <[email protected]>
Update to Segger repository with RTT / SystemView v3.58 source.

Signed-off-by: Bryce Wilkins <[email protected]>
@brycewilkins brycewilkins force-pushed the bw/manifest_segger_update branch from fe15d8f to 679e7f1 Compare December 17, 2024 14:05
@zephyrbot zephyrbot removed the DNM This PR should not be merged (Do Not Merge) label Dec 17, 2024
@brycewilkins
Copy link
Contributor Author

Thanks @kartben @henrikbrixandersen !

I made a little slip up rebasing to main and it looks like that, or the rebase itself, dismissed your approvals :/ It's good to go now.

@kartben
Copy link
Contributor

kartben commented Dec 17, 2024

Thanks @kartben @henrikbrixandersen !

I made a little slip up rebasing to main and it looks like that, or the rebase itself, dismissed your approvals :/ It's good to go now.

no worries, it was always gonna dismiss the approvals since you actually updated the west.yaml file :)

@kartben kartben merged commit 2594e96 into zephyrproject-rtos:main Dec 17, 2024
27 of 28 checks passed
@brycewilkins brycewilkins deleted the bw/manifest_segger_update branch December 17, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants