drivers: usb: uhc: initial support for UHC driver on Renesas RA family #82730

thenguyenyf · 2024-12-09T11:54:40Z

This PR to initial support for UHC driver on Renesas RA boards.

zephyrbot · 2024-12-09T11:55:37Z

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff

✅ All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

thenguyenyf · 2025-09-23T16:07:55Z

Last push just to rebase main

thenguyenyf · 2025-09-25T12:31:57Z

Hello @jfischer-no. Is there any chance this PR could be merged? All review items have been fixed but this PR is still blocked due to your change request. Could you please review and verify?

Hello @thenguyenyf #82730 (comment) still not addressed, , there is not reason to add board overlays.

Hello @jfischer-no . Please verify it

Hello @jfischer-no . Could you please revisit and verify this change?

drivers/usb/uhc/uhc_renesas_ra.c

jfischer-no · 2025-09-25T14:23:46Z

drivers/usb/uhc/uhc_renesas_ra.c

+		return -EINVAL;
+	}
+
+	usb_desc_endpoint_t ep0_desc = {.bLength = sizeof(usb_desc_endpoint_t),


Variable definition should be at the top of a block. Please fix style.
Why is the name ep0_desc?

Done. The name was changed to ep_desc

There is now unnecessary type conversion, please change it to

const struct uhc_renesas_ra_config *config = dev->config; usb_desc_endpoint_t ep_desc = { .bDescriptorType = USB_DT_ENDPOINT, .bEndpointAddress = ep, .bmAttributes = {attrib}, .wMaxPacketSize = mps, .bInterval = 0, }; fsp_err_t err;

drivers/usb/uhc/uhc_renesas_ra.c

drivers/usb/udc/Kconfig.renesas_ra

jfischer-no · 2025-09-25T14:37:20Z

dts/bindings/usb/renesas/renesas,ra-usbhs.yaml

+  bus-wait-cycles:
+    type: int
+    description: Specifies CPU bus access wait cycles
+


Stray change? I do not think it is UHC relevant. Where is it used?

It is a setting for this HWIP and being used in the HAL: https://github.com/zephyrproject-rtos/hal_renesas/blob/main/zephyr/ra/ra_cfg/fsp_cfg/r_usb_host_cfg.h#L33

This commit adds a new property that is already exclusively used in the HAL driver configuration. Devicetree should be used to configure drivers in Zephyr. The HAL driver or HAL module must not depend on anything from Zephyr. You have to fix it, see https://github.com/zephyrproject-rtos/zephyr/tree/main/modules, also there is no obligation to use HAL drivers.

Done. Normal use case does not need to change this setting. Removed this property from Zephyr DT link and configure it as fixed in HAL.

jfischer-no · 2025-09-25T14:41:28Z

drivers/usb/uhc/uhc_renesas_ra.c

+	static const struct uhc_renesas_ra_config uhc_config_##n = {                               \
+		.pcfg = PINCTRL_DT_DEV_CONFIG_GET(DT_INST_PARENT(n)),                              \
+		.make_thread = uhc_renesas_ra_create_thread_##n,                                   \
+		.udev_count = DT_PROP_OR(DT_INST_PARENT(node_id), usb_devices_count, 10),          \


Why is it a DT property and why does it need to be configured per instance? I see it only used in the shim driver. Why is 10 default value?

This HWIP only support up to 10 devices connected to. So, the 0xb or higher address is invalid for this driver.

why does it need to be configured per instance? Are there SoC variants where it has a different value?

Updated. Currently all device instances are limited to 5 max. Fixed in source code.

thenguyenyf · 2025-09-29T08:28:54Z

Hello @jfischer-no . Could you please re-visit this PR and verify the change request?

josuah

Hello all.
Some few practical details which you might be interested in before pursuing.

drivers/usb/uhc/uhc_renesas_ra.c

thenguyenyf · 2025-10-24T08:09:22Z

The failed compliance job is not related to update from this PR, under fixing by #98173

josuah · 2025-10-24T09:41:55Z

Thank you for the changes.

The CI should not raise this line as not changed by this patch but a small commit "fix coding style" at the beginning should fix it:

dts/arm/renesas/ra/ra8/ra8x1.dtsi:64 Expecting 1 space(s).
dts/arm/renesas/ra/ra8/ra8x1.dtsi:79 Expecting 0 space(s).
boards/renesas/ek_ra8d1/ek_ra8d1-pinctrl.dtsi:65 Expecting 2 new line(s)
cb81e85

In addition:

drivers/usb/uhc/uhc_renesas_ra.c:741 line length of 103 exceeds 100 columns

First commit to support UHC driver for Renesas RA family Signed-off-by: Minh Hoang <[email protected]> Signed-off-by: The Nguyen <[email protected]>

Add device node to support UHC on Renesas RA SoCs Signed-off-by: Minh Hoang <[email protected]> Signed-off-by: The Nguyen <[email protected]>

Enable USB host support on Renesas RA boards Signed-off-by: Minh Hoang <[email protected]> Signed-off-by: The Nguyen <[email protected]>

Support USBH shell sample for renesas,ra-uhc Signed-off-by: The Nguyen <[email protected]>

thenguyenyf · 2025-10-24T10:08:55Z

The failed compliance job is not related to update from this PR, under fixing by #98173

Rebase to get the workflow fix commit

KhiemNguyenT

LGTM. Thanks.

sonarqubecloud · 2025-10-24T11:15:37Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

zephyrbot added manifest manifest-hal_renesas DNM This PR should not be merged (Do Not Merge) labels Dec 9, 2024

thenguyenyf force-pushed the support_renesas_ra_uhc branch 6 times, most recently from 9356bc5 to 68f0507 Compare December 23, 2024 03:07

thenguyenyf marked this pull request as ready for review December 23, 2024 04:28

zephyrbot added platform: Renesas RA Renesas Electronics Corporation, RA area: Samples Samples area: USB Universal Serial Bus labels Dec 23, 2024

zephyrbot requested review from KhiemNguyenT, duynguyenxa, jfischer-no, kartben, nashif, soburi, thaoluonguw and tmon-nordic December 23, 2024 04:29

zephyrbot assigned jfischer-no Dec 23, 2024

thenguyenyf force-pushed the support_renesas_ra_uhc branch from 68f0507 to 00f6cce Compare December 23, 2024 09:53

tmon-nordic previously approved these changes Jan 9, 2025

View reviewed changes

fabiobaltieri added DNM (manifest) This PR should not be merged (controlled by action-manifest) and removed DNM This PR should not be merged (Do Not Merge) labels Feb 4, 2025

facchinm mentioned this pull request Feb 6, 2025

boards: support Arduino Portenta C33 #85337

Merged

16 tasks

thenguyenyf dismissed tmon-nordic’s stale review via 3ce519d February 17, 2025 08:58

thenguyenyf force-pushed the support_renesas_ra_uhc branch from 00f6cce to 3ce519d Compare February 17, 2025 08:58

jfischer-no reviewed Sep 25, 2025

View reviewed changes

jfischer-no requested review from josuah and removed request for JarmouniA and nashif September 25, 2025 19:49

thenguyenyf force-pushed the support_renesas_ra_uhc branch from 9a10f10 to dc43286 Compare September 26, 2025 02:46

zephyrbot requested review from JarmouniA and nashif September 26, 2025 02:48

thenguyenyf force-pushed the support_renesas_ra_uhc branch from dc43286 to 6303874 Compare September 26, 2025 02:55

thenguyenyf requested a review from jfischer-no September 26, 2025 04:05

josuah reviewed Oct 17, 2025

View reviewed changes

drivers/usb/uhc/uhc_renesas_ra.c Outdated Show resolved Hide resolved

drivers/usb/uhc/uhc_renesas_ra.c Outdated Show resolved Hide resolved

drivers/usb/uhc/uhc_renesas_ra.c Outdated Show resolved Hide resolved

drivers/usb/uhc/uhc_renesas_ra.c Outdated Show resolved Hide resolved

thenguyenyf force-pushed the support_renesas_ra_uhc branch from 6303874 to 36ea3e7 Compare October 24, 2025 06:09

zephyrbot added area: Devicetree Bindings area: Boards/SoCs labels Oct 24, 2025

thenguyenyf force-pushed the support_renesas_ra_uhc branch 2 times, most recently from 89d3182 to cb81e85 Compare October 24, 2025 08:08

thenguyenyf requested a review from josuah October 24, 2025 09:08

josuah approved these changes Oct 24, 2025

View reviewed changes

Minh Hoang and others added 4 commits October 24, 2025 10:07

drivers: usb: uhc: add support for Renesas RA USB host

73d13ea

First commit to support UHC driver for Renesas RA family Signed-off-by: Minh Hoang <[email protected]> Signed-off-by: The Nguyen <[email protected]>

dts: arm: renesas: add support for UHC on Renesas RA SoCs

660d9b8

Add device node to support UHC on Renesas RA SoCs Signed-off-by: Minh Hoang <[email protected]> Signed-off-by: The Nguyen <[email protected]>

boards: renesas: add support for Renesas RA USB host

25a5a92

Enable USB host support on Renesas RA boards Signed-off-by: Minh Hoang <[email protected]> Signed-off-by: The Nguyen <[email protected]>

samples: subsys: usb: shell: add support for renesas,ra-uhc

8ed3356

Support USBH shell sample for renesas,ra-uhc Signed-off-by: The Nguyen <[email protected]>

thenguyenyf force-pushed the support_renesas_ra_uhc branch from cb81e85 to 8ed3356 Compare October 24, 2025 10:08

KhiemNguyenT approved these changes Oct 24, 2025

View reviewed changes

drivers: usb: uhc: initial support for UHC driver on Renesas RA family #82730

Are you sure you want to change the base?

drivers: usb: uhc: initial support for UHC driver on Renesas RA family #82730

Conversation

thenguyenyf commented Dec 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zephyrbot commented Dec 9, 2024 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thenguyenyf commented Sep 23, 2025

Uh oh!

thenguyenyf commented Sep 25, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

thenguyenyf commented Sep 29, 2025

Uh oh!

josuah left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

thenguyenyf commented Oct 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

josuah commented Oct 24, 2025

Uh oh!

thenguyenyf commented Oct 24, 2025

Uh oh!

KhiemNguyenT left a comment

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Oct 24, 2025

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

thenguyenyf commented Dec 9, 2024 •

edited

Loading

zephyrbot commented Dec 9, 2024 •

edited by github-actions bot

Loading

thenguyenyf commented Oct 24, 2025 •

edited

Loading