samples: fix GPIO API usage issues #83058
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmarull
requested review from
fabiobaltieri,
henrikbrixandersen and
nordicjm
zephyrbot
requested review from
Thalley,
alwa-nordic,
anangl,
cvinayak,
hermabe,
jhedberg,
kartben,
masz-nordic,
nashif,
rugeGerritsen,
sjanc and
theob-pro
fabiobaltieri
previously approved these changes
Dec 16, 2024
kartben
requested changes
Dec 16, 2024
gmarull
force-pushed
the
gpio-missing-kconfig-samples
branch
from
3864c89 to
d9453d6
Compare
Thalley
requested changes
Dec 16, 2024
gmarull
force-pushed
the
gpio-missing-kconfig-samples
branch
from
d9453d6 to
064ad1a
Compare
gmarull
force-pushed
the
gpio-missing-kconfig-samples
branch
2 times, most recently
from
9d8c0fb to
3e97354
Compare
nordicjm
previously approved these changes
Dec 17, 2024
Thalley
reviewed
Dec 17, 2024
Contributor
Thalley
left a comment
Thalley
left a comment
There was a problem hiding this comment.
Changes LGTM
Some samples seem to optionally support GPIO but still has GPIO=y, but those are outside my area, so not sure whether these should be updated.
Will await with approval a bit
All samples using the GPIO API must enable the CONFIG_GPIO Kconfig option. Signed-off-by: Gerard Marull-Paretas <[email protected]>
Only include the header if using any of the GPIO API calls/ struct/defines. Signed-off-by: Gerard Marull-Paretas <[email protected]>
Add a new Kconfig option to control the behavior of led0. This option also allows to select GPIO only when needed. Signed-off-by: Gerard Marull-Paretas <[email protected]>
Add a new Kconfig option to control the behavior of sw0. If enabled, sw0 button will be used for provisioning. This option also allows to select GPIO. Signed-off-by: Gerard Marull-Paretas <[email protected]>
Add a new option to control led0 behavior. If enabled, led0 will be used for blinking. This option also allows to select GPIO when needed. Signed-off-by: Gerard Marull-Paretas <[email protected]>
Add a new option to control the behavior of sw0. This option also allows to select GPIO when needed. Signed-off-by: Gerard Marull-Paretas <[email protected]>
Add options to control the behavior of sw0/sw1. These options also allow to select GPIO when needed. Signed-off-by: Gerard Marull-Paretas <[email protected]>
gmarull
force-pushed
the
gpio-missing-kconfig-samples
branch
from
3e97354 to
4d6fa8c
Compare
Add a new option to control usage of DT nodelabel board_power. This option also allows to select GPIO when needed. Signed-off-by: Gerard Marull-Paretas <[email protected]>
Kconfigs enabled functionality that requires GPIO, but they did not select GPIO. Signed-off-by: Gerard Marull-Paretas <[email protected]>
gmarull
force-pushed
the
gpio-missing-kconfig-samples
branch
from
4d6fa8c to
8f79d1e
Compare
Thalley
approved these changes
Dec 17, 2024
nordicjm
approved these changes
Dec 17, 2024
kartben
approved these changes
Dec 17, 2024
masz-nordic
approved these changes
Dec 18, 2024
jhedberg
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A tiny step towards the removal of
CONFIG_GPIO=yfrom all boards.